ucberkeley/moocchat

View on GitHub

Showing 95 of 132 total issues

Method evaluateQualificationRequests has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evaluateQualificationRequests has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 3 hrs to fix

    Method loadHITs has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      public HIT[] loadHITs(String input, String question, String props, 
          String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {
    
        HITDataInput hi = new HITDataCSVReader(input);
        HITProperties hc = new HITProperties(props);
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findMostFrequent has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String findMostFrequent(List<String> answers, int[] numMostFreqVotes, int numAssignments) throws UnresolvedAnswerException {
            if(answers == null || answers.size() == 0){
                throw new UnresolvedAnswerException("No answers submitted", ErrorReason.InProgress);
            }
    
    
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/summary/SummaryUtils.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createQualificationType has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public boolean createQualificationType(String qualFile, String answerFile,
          String propertiesFile, boolean noRetry) {
        String test = null;
        String answerKey = null;
        Properties props = new Properties();
    Severity: Major
    Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 3 hrs to fix

      Method loadHITs has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public HIT[] loadHITs(String input, String question, String props, 
            String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {
      
          HITDataInput hi = new HITDataCSVReader(input);
          HITProperties hc = new HITProperties(props);
      Severity: Major
      Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 2 hrs to fix

        Function showWelcomeMessage has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

          showWelcomeMessage: function(){
            if (this.group.length == 1) {
              this.showMessage("No one is currently available to chat with you. You may use this chatroom to reflect on the question. Click the end button above when done.", "system");
            } else if (this.group.length == 2) {
              var you_learner = '';
        Severity: Minor
        Found in app/assets/javascripts/web_socket.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method updateHITs has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public HIT[] updateHITs(String successFile, String props) throws Exception {
        
            HITProperties hc = new HITProperties(props);
        
            // Output initializing message
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/UpdateHITs.java - About 2 hrs to fix

          Method processAnswers has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

            private void processAnswers(Map<String, String> values) {
              String answers = values.get(ORIG_ANSWER_FIELD);
          
              if (answers == null || HITResults.NO_ANSWER.equals(answers)) {
                return ;  // return if no answers
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/util/HITResultProcessor.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateQualificationType has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public void updateQualificationType( String qualTypeId, String statusString,
                String questionFile, String answerFile, 
                String propertiesFile ) throws Exception
            {
              String test = null;
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 2 hrs to fix

            Method updateStatistics has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              private void updateStatistics(HITResults r) {
                totalAssignments += r.getHIT().getMaxAssignments();
                
                if (r.getHIT().getCreationTime().before(firstHitCreateTime)) {
                  firstHitCreateTime=r.getHIT().getCreationTime();
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/GetResults.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createQualificationType has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              public boolean createQualificationType(String qualFile, String answerFile,
                  String propertiesFile, boolean noRetry) {
                String test = null;
                String answerKey = null;
                Properties props = new Properties();
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method approveAssignmentsInFile has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              public void approveAssignmentsInFile(String fileName) throws IOException {
                if (fileName == null) {
                  throw new IllegalArgumentException("fileName must not be null");
                }
                
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method reviewAssignments has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              public void reviewAssignments(String fileName) throws IOException {
                if (fileName == null) {
                  throw new IllegalArgumentException("File name is null.");
                }
                
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/ReviewResults.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method updateQualificationType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

              public void updateQualificationType( String qualTypeId, String statusString,
                  String questionFile, String answerFile, 
                  String propertiesFile ) throws Exception
              {
                String test = null;
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method runCommand has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

              protected void runCommand(CommandLine cmdLine) throws Exception {
                if (!cmdLine.hasOption(QUAL_TYPE) &&
                    !cmdLine.hasOption(INPUT_FILE)) {
            
                  log.error("Either -" + QUAL_TYPE + " or -" + INPUT_FILE + " should be passed");
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method sendMessage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

              private Reply sendMessage(Message m) {
                Reply ret = null;
                while (ret == null) {
                  try {
                    ret = passMessage(m);
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/util/CLTExceptionFilter.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method reviewAssignments has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public void reviewAssignments(String fileName) throws IOException {
                if (fileName == null) {
                  throw new IllegalArgumentException("File name is null.");
                }
                
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/ReviewResults.java - About 1 hr to fix

              Method runCommand has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                protected void runCommand(CommandLine cmdLine) throws Exception {
              
                  if (!cmdLine.hasOption(ARG_TEMPLATE)) {
                    log.error("Missing: -" + ARG_TEMPLATE);
                    printHelp();
              Severity: Minor
              Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 1 hr to fix

                Method runCommand has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  protected void runCommand(CommandLine cmdLine) throws Exception {
                    if (!cmdLine.hasOption(ARG_INPUT)) {
                
                      log.error("Missing: -" + ARG_INPUT 
                          + " [path to input file -- ie. c:\\mturk\\helloworld.input]");
                Severity: Minor
                Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language