Sign upLogin

uclouvain/osis-dissertation

View on GitHub
Star
models/dissertation.py

Summary

Maintainability
C
1 day
Test Coverage

Function get_next_status has a Cognitive Complexity of 26 (exceeds 8 allowed). Consider refactoring.
Open

def get_next_status(dissert, operation):
    if operation == "go_forward":
        if dissert.status == 'DRAFT' or dissert.status == 'DIR_KO':
            return 'DIR_SUBMIT'
Severity: Minor
Found in models/dissertation.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if offer_prop.validation_commission_exists and dissert.status == 'DIR_SUBMIT':

            return 'COM_SUBMIT'

        elif offer_prop.evaluation_first_year and (dissert.status == 'DIR_SUBMIT' or
Severity: Major
Found in models/dissertation.py - About 40 mins to fix

    Avoid too many return statements within this function.
    Open

                return 'COM_SUBMIT'
    Severity: Major
    Found in models/dissertation.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 'EVA_SUBMIT'
      Severity: Major
      Found in models/dissertation.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return 'DIR_KO'
        Severity: Major
        Found in models/dissertation.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return dissert.status
          Severity: Major
          Found in models/dissertation.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return dissert.status
            Severity: Major
            Found in models/dissertation.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return 'EVA_KO'
              Severity: Major
              Found in models/dissertation.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return dissert.status
                Severity: Major
                Found in models/dissertation.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return 'TO_RECEIVE'
                  Severity: Major
                  Found in models/dissertation.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return 'TO_RECEIVE'
                    Severity: Major
                    Found in models/dissertation.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return 'ENDED_LOS'
                      Severity: Major
                      Found in models/dissertation.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return 'ENDED_WIN'
                        Severity: Major
                        Found in models/dissertation.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return 'COM_KO'
                          Severity: Major
                          Found in models/dissertation.py - About 30 mins to fix

                            There are no issues that match your filters.

                            Category
                            Status