Sign upLogin

ucsdlib/damspas

View on GitHub
Star
app/helpers/catalog_helper.rb

Summary

Maintainability
C
1 day
Test Coverage

Method date_list has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def date_list( document )
    dateVal = ''
    dates = document['date_json_tesim']
    if dates != nil
      dates.each do |txt|
Severity: Minor
Found in app/helpers/catalog_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method display_access_control_level has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def display_access_control_level(document, metadata_colls, mix_obj, meta_only_obj)
    access_group = document['read_access_group_ssim'] # "public" > "local" > "dams-curator" == "dams-rci" == default
    view_access = 'Curator Only'
    if access_group
      if metadata_colls.include?("#{document['id']}true") || mix_obj
Severity: Minor
Found in app/helpers/catalog_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method link_to_document has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def link_to_document(doc, opts={:label => nil, :counter => nil, :results_view => true, :force_label => false})

    opts[:label] ||= blacklight_config.index.show_link.to_sym

    if opts[:force_label]
Severity: Minor
Found in app/helpers/catalog_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          dateVal += ", " if !dateVal.blank?
Severity: Major
Found in app/helpers/catalog_helper.rb - About 45 mins to fix

    Method document_icon has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def document_icon( document )
    # generic default icon
    resultClass = 'thumb-simple'
    resultIcon = 'glyphicon-file'
    Severity: Minor
    Found in app/helpers/catalog_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method should_render_index_field? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def should_render_index_field? document, solr_field
    if !(solr_field.is_a? Symbol) && !(solr_field.is_a? String)
      hitsonly = solr_field.hitsonly
    end
    if (hitsonly)
    Severity: Minor
    Found in app/helpers/catalog_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method object_thumbnail_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def object_thumbnail_url(document)
    restricted_view = metadata_display?(rights_data(document))
    return nil unless restricted_view || (has_thumbnail?(document) && thumbnail_url(document, nil))
    if restricted_view && cannot?(:read, document)
      url = 'https://library.ucsd.edu/assets/dams/site/thumb-restricted.png'
    Severity: Minor
    Found in app/helpers/catalog_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def grabGlyphicon(fileUse)
    icon = grabFileType(fileUse)
    case icon
      when 'image'
        icon = 'glyphicon-picture'
    Severity: Minor
    Found in app/helpers/catalog_helper.rb and 1 other location - About 25 mins to fix
    app/helpers/dams_objects_helper.rb on lines 511..525

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if field_data != nil
      field_data.each do |datum|
        files = JSON.parse(datum)
        if files["use"].end_with?("-service")
          simpleUse = files["use"]
    Severity: Minor
    Found in app/helpers/catalog_helper.rb and 1 other location - About 15 mins to fix
    app/helpers/dams_objects_helper.rb on lines 424..430

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status