Sign upLogin

udondan/iam-floyd

View on GitHub
Star
docs/source/_static/js/policy-converter.js

Summary

Maintainability
F
3 days
Test Coverage

Function makeStatementCode has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

function makeStatementCode(
  language,
  effect,
  service,
  actions,
Severity: Minor
Found in docs/source/_static/js/policy-converter.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File policy-converter.js has 415 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var preferredLanguage = 'TypeScript';
var preferredVariant = 'CDK';
var preferredImports = 'Yes';

var selectFilled = false;
Severity: Minor
Found in docs/source/_static/js/policy-converter.js - About 5 hrs to fix

    Function makeStatementCode has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function makeStatementCode(
  language,
  effect,
  service,
  actions,
    Severity: Major
    Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

      Function convert has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      function convert(convertTarget, data) {
  if (!data.hasOwnProperty('Statement')) {
    setError('Policy has no statements');
    return;
  }
      Severity: Minor
      Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convert has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function convert(convertTarget, data) {
  if (!data.hasOwnProperty('Statement')) {
    setError('Policy has no statements');
    return;
  }
      Severity: Major
      Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

        Function makeStatementCode has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          language,
  effect,
  service,
  actions,
  resources,
        Severity: Major
        Found in docs/source/_static/js/policy-converter.js - About 1 hr to fix

          Function splitActionsByService has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function splitActionsByService(actions) {
  const serviceActions = {};
  for (let action of actions) {
    const split = action.split(':');
    if (split.length == 1 && action != '*') {
          Severity: Minor
          Found in docs/source/_static/js/policy-converter.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function makeMethodCall has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function makeMethodCall(method, params = []) {
  let code = '.' + method + '(';
  if (params.length) {
    const paramList = [];
    for (let param of params) {
          Severity: Minor
          Found in docs/source/_static/js/policy-converter.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case 'JavaScript':
        if (preferredVariant == 'CDK') {
          output += "const { aws_iam } = require('aws-cdk-lib');\n";
        }
        package = preferredVariant == 'CDK' ? 'cdk-iam-floyd' : 'iam-floyd';
          Severity: Major
          Found in docs/source/_static/js/policy-converter.js and 1 other location - About 1 hr to fix
          docs/source/_static/js/policy-converter.js on lines 154..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case 'TypeScript':
        if (preferredVariant == 'CDK') {
          output += "import { aws_iam } from 'aws-cdk-lib';\n";
        }
        package = preferredVariant == 'CDK' ? 'cdk-iam-floyd' : 'iam-floyd';
          Severity: Major
          Found in docs/source/_static/js/policy-converter.js and 1 other location - About 1 hr to fix
          docs/source/_static/js/policy-converter.js on lines 161..167

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status