Sign upLogin

udondan/iam-floyd

View on GitHub
Star

Showing 97 of 99 total issues

File index.ts has 892 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import 'colors';

import * as cheerio from 'cheerio';
import * as fs from 'fs';
import * as glob from 'glob';
Severity: Major
Found in lib/generator/index.ts - About 2 days to fix

    Function createModule has 329 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function createModule(module: Module): Promise<void> {
  const stats: Stats = {
    actions: [],
    conditions: [],
    resources: [],
    Severity: Major
    Found in lib/generator/index.ts - About 1 day to fix

      Function createModule has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
      Open

      export function createModule(module: Module): Promise<void> {
  const stats: Stats = {
    actions: [],
    conditions: [],
    resources: [],
      Severity: Minor
      Found in lib/generator/index.ts - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function deployAssume(statements: any[]): Promise<void> {
  return new Promise(async function (resolve, reject) {
    const roleName = newRandomName();

    log(`Creating test role ${roleName}...`);
      Severity: Major
      Found in helper/typescript/typescript_test.ts and 1 other location - About 6 hrs to fix
      helper/typescript/typescript_test.ts on lines 69..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 172.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function deployPolicy(statements: PolicyStatement[]): Promise<void> {
  return new Promise(async function (resolve, reject) {
    const policyName = newRandomName();

    log(`Creating test policy ${policyName}...`);
      Severity: Major
      Found in helper/typescript/typescript_test.ts and 1 other location - About 6 hrs to fix
      helper/typescript/typescript_test.ts on lines 101..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 172.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function makeStatementCode has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

      function makeStatementCode(
  language,
  effect,
  service,
  actions,
      Severity: Minor
      Found in docs/source/_static/js/policy-converter.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File policy-converter.js has 415 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      var preferredLanguage = 'TypeScript';
var preferredVariant = 'CDK';
var preferredImports = 'Yes';

var selectFilled = false;
      Severity: Minor
      Found in docs/source/_static/js/policy-converter.js - About 5 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          public ifAwsCurrentTime(
    value: Date | string | (Date | string)[],
    operator?: Operator | string,
  ) {
    if (typeof (value as Date).getMonth === 'function') {
        Severity: Major
        Found in lib/shared/policy-statement/2-conditions.ts and 1 other location - About 5 hrs to fix
        lib/shared/policy-statement/2-conditions.ts on lines 257..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 151.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          public ifAwsEpochTime(
    value: number | Date | string | (number | Date | string)[],
    operator?: Operator | string,
  ) {
    if (typeof (value as Date).getMonth === 'function') {
        Severity: Major
        Found in lib/shared/policy-statement/2-conditions.ts and 1 other location - About 5 hrs to fix
        lib/shared/policy-statement/2-conditions.ts on lines 182..201

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 151.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File 2-conditions.ts has 352 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import { Operator } from '../operators';
import { PolicyStatementBase } from './1-base';

/**
 * A Condition
        Severity: Minor
        Found in lib/shared/policy-statement/2-conditions.ts - About 4 hrs to fix

          Function makeStatementCode has 88 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function makeStatementCode(
  language,
  effect,
  service,
  actions,
          Severity: Major
          Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

            Function convert has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
            Open

            function convert(convertTarget, data) {
  if (!data.hasOwnProperty('Statement')) {
    setError('Policy has no statements');
    return;
  }
            Severity: Minor
            Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addActions has 78 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function addActions($: cheerio.Root, module: Module): Module {
  const actions: Actions = {};
  const tableActions = getTable($, 'Actions');

  let action: string;
            Severity: Major
            Found in lib/generator/index.ts - About 3 hrs to fix

              Function convert has 77 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function convert(convertTarget, data) {
  if (!data.hasOwnProperty('Statement')) {
    setError('Policy has no statements');
    return;
  }
              Severity: Major
              Found in docs/source/_static/js/policy-converter.js - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                if (
  process.env.AWS_ACCESS_KEY_ID &&
  process.env.AWS_SECRET_ACCESS_KEY &&
  process.env.AWS_SESSION_TOKEN
) {
                Severity: Major
                Found in lib/generator/managed-policies.ts and 1 other location - About 2 hrs to fix
                helper/typescript/typescript_test.ts on lines 26..36

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                if (
  process.env.AWS_ACCESS_KEY_ID &&
  process.env.AWS_SECRET_ACCESS_KEY &&
  process.env.AWS_SESSION_TOKEN
) {
                Severity: Major
                Found in helper/typescript/typescript_test.ts and 1 other location - About 2 hrs to fix
                lib/generator/managed-policies.ts on lines 132..142

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function compactActions has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private compactActions() {
    // actions that will be included, service prefix is removed
    const includeActions = this.floydActions.map((elem) => {
      return elem.substring(elem.indexOf(':') + 1);
    });
                Severity: Major
                Found in lib/shared/policy-statement/3-actions.ts - About 2 hrs to fix

                  File fixes.ts has 261 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import { get } from 'lodash';

import { Condition } from './condition';

const colors = require('colors/safe');
                  Severity: Minor
                  Found in lib/generator/fixes.ts - About 2 hrs to fix

                    Function constructor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    Tags.of(scope).add('Project', project);
                    Severity: Major
                    Found in tooter/lib/index.ts - About 2 hrs to fix

                      PolicyStatementWithPrincipal has 21 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      export class PolicyStatementWithPrincipal extends PolicyStatementWithArnDefaults {
  protected useNotPrincipal = false;
  protected myPrincipals: Principals = {};

  /**
                      Severity: Minor
                      Found in lib/shared/policy-statement/8-principals.ts - About 2 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language