Sign upLogin

uhlibraries-digital/greens

View on GitHub
Star

Showing 3 of 3 total issues

Method mint has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def mint
    if Settings.naan.nil? or Settings.naan.empty?
      return api_error(status: 500, errors: 'Missing NAAN in server configuration')
    end
Severity: Minor
Found in app/controllers/api/v1/arks_controller.rb - About 1 hr to fix

    Method mint has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def mint
    if Settings.naan.nil? or Settings.naan.empty?
      return api_error(status: 500, errors: 'Missing NAAN in server configuration')
    end
    Severity: Minor
    Found in app/controllers/api/v1/arks_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def show
    parts = params[:id].match(/(ark:\/[^\/]*\/[^\/]*)([\/\.].*)/)
    if parts.nil?
      id = params[:id]
      suffix = ''
    Severity: Minor
    Found in app/controllers/arks_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language