Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star
app/javascript/src/collected_inks/cards/SwabCard.spec.jsx

Summary

Maintainability
F
4 days
Test Coverage

File SwabCard.spec.jsx has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @ts-check
import React from "react";
import { render } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { SwabCard } from "./SwabCard";
Severity: Minor
Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("renders a maker heading if there's a maker", () => {
    const { getByText } = setup(
      <SwabCard
        id="1"
        ink_id="1"
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 1 other location - About 3 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 208..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("renders comments", () => {
    const { getByText } = setup(
      <SwabCard
        id="1"
        ink_id="1"
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 1 other location - About 3 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 175..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("doesn't render a usage header if there are no stats", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        ink_id="1"
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 3 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 192..206
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 283..297

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders no maker heading if there's no maker", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        ink_id="1"
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 3 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 249..263
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 283..297

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders no maker heading if there's no maker", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        ink_id="1"
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 3 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 192..206
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 249..263

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders a Private-badge if private", () => {
    const { getByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 45..58
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 74..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders a Used-badge if used", () => {
    const { getByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 16..29
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 45..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders a Swabbed-badge if swabbed", () => {
    const { getByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 16..29
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 74..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders no Private-badge if public", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 60..72
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 89..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders no Used-badge if unused", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 31..43
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 60..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      it("renders no Swabbed-badge if not swabbed", () => {
    const { queryByText } = setup(
      <SwabCard
        id="1"
        archived={false}
    Severity: Major
    Found in app/javascript/src/collected_inks/cards/SwabCard.spec.jsx and 2 other locations - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 31..43
    app/javascript/src/collected_inks/cards/SwabCard.spec.jsx on lines 89..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status