Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star
app/javascript/src/collected_pens/cards/PenCard.jsx

Summary

Maintainability
D
3 days
Test Coverage

Function PenCard has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const PenCard = (props) => {
  const {
    hiddenFields,
    id,
    brand,
Severity: Major
Found in app/javascript/src/collected_pens/cards/PenCard.jsx - About 4 hrs to fix

    Function PenCard has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export const PenCard = (props) => {
  const {
    hiddenFields,
    id,
    brand,
    Severity: Minor
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <div className="fpc-pen-card__actions">
            <a
              className="btn btn-secondary me-2"
              title="edit"
              href={`/collected_pens/${id}/edit`}
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 1 other location - About 4 hrs to fix
    app/javascript/src/collected_pens/table/ActionsCell.jsx on lines 5..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {hasUsage ? (
          <>
            <div className="small text-secondary">Usage</div>
            <Card.Text data-testid="usage">
              {String(usage)} inked -{" "}
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 1 other location - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 99..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {isVisible("created_at") ? (
          <>
            <div className="small text-secondary">Added On</div>
            <Card.Text>
              {<RelativeDate date={created_at} relativeAsDefault={false} />}
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 1 other location - About 2 hrs to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 109..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const LastUsageDisplay = ({ last_used_on }) => {
  if (last_used_on) {
    return (
      <>
        last used <RelativeDate date={last_used_on} />
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 1 other location - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 180..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("material") ? (
          <>
            <div className="small text-secondary">Material</div>
            <Card.Text>{material}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 56..61
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 62..67
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 74..79
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 80..85
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 86..91
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("color") ? (
          <>
            <div className="small text-secondary">Color</div>
            <Card.Text>{color}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 62..67
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 68..73
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 74..79
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 80..85
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 86..91
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("filling_system") ? (
          <>
            <div className="small text-secondary">Filling System</div>
            <Card.Text>{filling_system}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 56..61
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 62..67
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 68..73
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 74..79
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 86..91
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("price") ? (
          <>
            <div className="small text-secondary">Price</div>
            <Card.Text>{price}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 56..61
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 62..67
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 68..73
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 74..79
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 80..85
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("trim_color") ? (
          <>
            <div className="small text-secondary">Trim Color</div>
            <Card.Text>{trim_color}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 56..61
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 62..67
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 68..73
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 80..85
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 86..91
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            {isVisible("nib") ? (
          <>
            <div className="small text-secondary">Nib</div>
            <Card.Text>{nib}</Card.Text>
          </>
    Severity: Major
    Found in app/javascript/src/collected_pens/cards/PenCard.jsx and 9 other locations - About 1 hr to fix
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 87..92
    app/javascript/src/collected_inks/cards/SwabCard.jsx on lines 93..98
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 56..61
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 68..73
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 74..79
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 80..85
    app/javascript/src/collected_pens/cards/PenCard.jsx on lines 86..91
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 67..72
    app/javascript/src/currently_inked/cards/CurrentlyInkedCard.jsx on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status