Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star
app/models/collected_ink.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class CollectedInk has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class CollectedInk < ApplicationRecord
  include Archivable
  include PgSearch::Model

  KINDS = %w[bottle sample cartridge swab]
Severity: Minor
Found in app/models/collected_ink.rb - About 3 hrs to fix

    Method to_csv has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.to_csv
    CSV.generate(col_sep: ";") do |csv|
      csv << [
        "Brand",
        "Line",
    Severity: Minor
    Found in app/models/collected_ink.rb - About 1 hr to fix

      Method add_comment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_comment
    unless changed.any? { |c| %w[brand_name line_name ink_name].include?(c) }
      return
    end
    return unless comment.blank?
      Severity: Minor
      Found in app/models/collected_ink.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status