Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star

Showing 377 of 377 total issues

Function ActualInkAddButton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const ActualInkAddButton = ({ macro_cluster_id, inCollection, detailView }) => {
  const [state, setState] = useState(null);
  const [kind, setKind] = useState("bottle");
  const add = () => {
    setState("adding");
Severity: Minor
Found in app/javascript/src/add-ink-button/app.jsx - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return "thorntons" if name =~ /^thornton/i
Severity: Major
Found in app/models/simplifier.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return "lecritoire" if simplified =~ /^lecritoire/
    Severity: Major
    Found in app/models/simplifier.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return "banmi" if name =~ /^ban\s*mi/i
      Severity: Major
      Found in app/models/simplifier.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return "robertoster" if name =~ /^robert\s*oster/i
        Severity: Major
        Found in app/models/simplifier.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return "birminghampens" if name =~ /^birmingham/i
          Severity: Major
          Found in app/models/simplifier.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return "organicsstudio" if simplified =~ /^organics?studios?$/
            Severity: Major
            Found in app/models/simplifier.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return "pensalley" if simplified =~ /pensalley/
              Severity: Major
              Found in app/models/simplifier.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return "pilot" if name =~ /iroshizuku/i
                Severity: Major
                Found in app/models/simplifier.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return "bril" if name =~ /^bril/i
                  Severity: Major
                  Found in app/models/simplifier.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return "lamy" if name =~ /^lamy/i
                    Severity: Major
                    Found in app/models/simplifier.rb - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return sortByElement(colorA, colorB, 2);
                      Severity: Major
                      Found in app/javascript/src/color-sorting.js - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return "kobe" if name =~ /^nagasawa/i
                        Severity: Major
                        Found in app/models/simplifier.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                              return "herbin" if name =~ /herbin/i
                          Severity: Major
                          Found in app/models/simplifier.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return "maruzen" if name =~ /^maruzen/i
                            Severity: Major
                            Found in app/models/simplifier.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                  return "sbre" if name =~ /^sbre\s*(brown)?$/i
                              Severity: Major
                              Found in app/models/simplifier.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                    return "kwz" if name =~ /^kwz/i
                                Severity: Major
                                Found in app/models/simplifier.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                      return "noodlers" if name =~ /^noodler/i
                                  Severity: Major
                                  Found in app/models/simplifier.rb - About 30 mins to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                              <a className="btn btn-secondary" onClick={() => this.onClick()}>
            {this.buttonText()}
          </a>
                                    Severity: Minor
                                    Found in app/javascript/src/friends/index.jsx and 1 other location - About 30 mins to fix
                                    app/javascript/src/friends/index.jsx on lines 82..84

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 45.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            <a className="btn btn-secondary" onClick={() => this.onClick()}>
          {this.buttonText()}
        </a>
                                    Severity: Minor
                                    Found in app/javascript/src/friends/index.jsx and 1 other location - About 30 mins to fix
                                    app/javascript/src/friends/index.jsx on lines 74..76

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 45.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language