Sign upLogin

ujiro99/tlt

View on GitHub
Star
src/eventPage.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function startTrackingForCalendarEvent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const startTrackingForCalendarEvent = async (eventId: string) => {
  const trackings = (await Storage.get(
    STORAGE_KEY.TRACKING_STATE,
  )) as TrackingState[]
  const eventLines = (await Storage.get(
Severity: Minor
Found in src/eventPage.ts - About 1 hr to fix

    Function setAlarm has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      setAlarm(param: Alarm, sendResponse: () => void) {
    const alarm = new Alarm({
      type: param.type,
      name: param.name,
      message: param.message,
    Severity: Minor
    Found in src/eventPage.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            const alarm = new Alarm({
        type: param.type,
        name: param.name,
        message: param.message,
        when: param.scheduledTime,
      Severity: Major
      Found in src/eventPage.ts and 1 other location - About 1 hr to fix
      src/models/alarm.ts on lines 30..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (
          obj.type === ALARM_TYPE.EVENT &&
          obj.calendarEventId === param.calendarEventId
        ) {
          Log.d(`clear alarm: ${obj.name} | ${obj.message}`)
      Severity: Major
      Found in src/eventPage.ts and 1 other location - About 1 hr to fix
      src/eventPage.ts on lines 148..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (obj.type === ALARM_TYPE.TASK) {
          Log.d(`clear alarm: ${obj.name} | ${obj.message}`)
          return chrome.alarms.clear(alarm.name)
        }
      Severity: Major
      Found in src/eventPage.ts and 1 other location - About 1 hr to fix
      src/eventPage.ts on lines 107..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status