Sign upLogin

uken/fluent-plugin-elasticsearch

View on GitHub
Star
lib/fluent/plugin/out_elasticsearch_data_stream.rb

Summary

Maintainability
D
1 day
Test Coverage

Method write has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def write(chunk)
      data_stream_name = @data_stream_name
      data_stream_template_name = @data_stream_template_name
      data_stream_ilm_name = @data_stream_ilm_name
      host = nil
Severity: Minor
Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_data_stream_parameters has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_data_stream_parameters
      {"data_stream_name" => @data_stream_name,
       "data_stream_template_name"=> @data_stream_template_name,
       "data_stream_ilm_name" => @data_stream_ilm_name}.each do |parameter, value|
        unless valid_data_stream_parameters?(value)
Severity: Minor
Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method write has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def write(chunk)
      data_stream_name = @data_stream_name
      data_stream_template_name = @data_stream_template_name
      data_stream_ilm_name = @data_stream_ilm_name
      host = nil
Severity: Major
Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 2 hrs to fix

    File out_elasticsearch_data_stream.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_relative 'out_elasticsearch'

module Fluent::Plugin
  class ElasticsearchOutputDataStream < ElasticsearchOutput
    Severity: Minor
    Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 2 hrs to fix

      Method configure has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def configure(conf)
      super

      if Gem::Version.new(TRANSPORT_CLASS::VERSION) < Gem::Version.new("8.0.0")
        begin
      Severity: Minor
      Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method configure has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def configure(conf)
      super

      if Gem::Version.new(TRANSPORT_CLASS::VERSION) < Gem::Version.new("8.0.0")
        begin
      Severity: Minor
      Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 1 hr to fix

        Method append_record_to_messages has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def append_record_to_messages(op, meta, header, record, msgs)
        Severity: Minor
        Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 35 mins to fix

          Method create_ilm_policy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def create_ilm_policy(datastream_name, template_name, ilm_name, host = nil)
      unless @data_stream_ilm_policy_overwrite
        return if data_stream_exist?(datastream_name, host) or template_exists?(template_name, host) or ilm_policy_exists?(ilm_name, host)
      end
          Severity: Minor
          Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def template_exists?(name, host = nil)
      if @use_legacy_template
        client(host).indices.get_template(:name => name)
      else
        client(host).indices.get_index_template(:name => name)
          Severity: Minor
          Found in lib/fluent/plugin/out_elasticsearch_data_stream.rb and 1 other location - About 30 mins to fix
          lib/fluent/plugin/elasticsearch_index_template.rb on lines 24..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status