Sign upLogin

uktrade/directory-components

View on GitHub
Star
directory_components/templatetags/directory_components.py

Summary

Maintainability
B
6 hrs
Test Coverage

File directory_components.py has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from bs4 import BeautifulSoup
import re

from collections import namedtuple
Severity: Minor
Found in directory_components/templatetags/directory_components.py - About 3 hrs to fix

    Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def render(self, context):
        html = self.nodelist.render(context)
        soup = BeautifulSoup(html, 'html.parser')

        selector = self.target.resolve(context)
    Severity: Minor
    Found in directory_components/templatetags/directory_components.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, nodelist,
    Severity: Major
    Found in directory_components/templatetags/directory_components.py - About 50 mins to fix

      Function ga360_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def ga360_data(parser, token):
    nodelist = parser.parse(('end_ga360_data',))
    parser.delete_first_token()

    # the ga360_data tag expects arguments in the following format
      Severity: Minor
      Found in directory_components/templatetags/directory_components.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status