Sign upLogin

uktrade/jwt-postgresql-proxy

View on GitHub
Star

Showing 4 of 4 total issues

Function main has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

def main():
    env = normalise_environment(os.environ)
    UPSTREAM__HOST = env['UPSTREAM']['HOST']
    UPSTREAM__PORT = env['UPSTREAM']['PORT']
    UPSTREAM__PASSWORD = env['UPSTREAM']['PASSWORD']
Severity: Minor
Found in jwt_postgresql_proxy.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File jwt_postgresql_proxy.py has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from gevent import monkey
monkey.patch_all()

from base64 import urlsafe_b64decode
from hashlib import md5
Severity: Minor
Found in jwt_postgresql_proxy.py - About 3 hrs to fix

    Function with_application has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def with_application():
    def decorator(original_test):
        def test_with_application(self):
            process = subprocess.Popen(
                ['python3', '-m', 'jwt_postgresql_proxy'],
    Severity: Minor
    Found in test.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def main():
    env = normalise_environment(os.environ)
    UPSTREAM__HOST = env['UPSTREAM']['HOST']
    UPSTREAM__PORT = env['UPSTREAM']['PORT']
    UPSTREAM__PASSWORD = env['UPSTREAM']['PASSWORD']
    Severity: Minor
    Found in jwt_postgresql_proxy.py - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language