Sign upLogin

uktrade/lite-forms

View on GitHub
Star
submitters.py

Summary

Maintainability
C
1 day
Test Coverage

Function submit_paged_form has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

def submit_paged_form(  # noqa
    request, form_group: FormGroup, action: Callable, object_pk=None, inject_data=None, additional_context: dict = None,
):
    """
    Function to handle the submission of the data from one form in a sequence of forms (a FormGroup).
Severity: Minor
Found in submitters.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if question.prefix in key:
                        exists = True
                        continue
                elif hasattr(question, "name"):
Severity: Major
Found in submitters.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if question.name == key:
                        exists = True
                        continue
    Severity: Major
    Found in submitters.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          for sub_value in value:
                        current_form.questions.insert(0, HiddenField(key + "[]", sub_value))
                else:
      Severity: Major
      Found in submitters.py - About 45 mins to fix

        Function _prepare_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def _prepare_data(request, inject_data):
    data = request.POST.copy()

    # Handle lists (such as checkboxes)
    data = handle_lists(data)
        Severity: Minor
        Found in submitters.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status