Sign upLogin

ulmic/tramway-dev

View on GitHub
Star

Showing 38 of 38 total issues

Function displayImages has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        displayImages: function() {
            var self = this,
                ws = [],
                rowNum = 0,
                baseLine = 0,
Severity: Major
Found in tramway-landing/app/assets/javascripts/justified_images.js - About 5 hrs to fix

    Function SmoothScroll has 127 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var SmoothScroll = function (selector, options) {

        //
        // Variables
        //
    Severity: Major
    Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 5 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          while (tw > availableRowWidth) {
                        var div2 = domRow.find('.' + this.options.imageContainer + ':nth-child(' + (k + 1) + ')'),
                            img2 = div2.find('.' + this.options.imageSelector);
                        img2.width(img2.width() - 1);
                        k = (k + 1) % c;
      Severity: Major
      Found in tramway-landing/app/assets/javascripts/justified_images.js and 1 other location - About 3 hrs to fix
      tramway-landing/app/assets/javascripts/justified_images.js on lines 180..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          while (tw < availableRowWidth) {
                        var div1 = domRow.find('.' + this.options.imageContainer + ':nth-child(' + (k + 1) + ')'),
                            img1 = div1.find('.' + this.options.imageSelector);
                        img1.width(img1.width() + 1);
                        k = (k + 1) % c;
      Severity: Major
      Found in tramway-landing/app/assets/javascripts/justified_images.js and 1 other location - About 3 hrs to fix
      tramway-landing/app/assets/javascripts/justified_images.js on lines 191..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File smooth-scroll.js has 277 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
 * smooth-scroll v12.1.5: Animate scrolling to anchor links
 * (c) 2017 Chris Ferdinandi
 * MIT License
 * http://github.com/cferdinandi/smooth-scroll
      Severity: Minor
      Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                    if (
                // If the character is in the range [\1-\1F] (U+0001 to U+001F) or is
                // U+007F, […]
                (codeUnit >= 0x0001 && codeUnit <= 0x001F) || codeUnit == 0x007F ||
                // If the character is the first character and is in the range [0-9]
        Severity: Critical
        Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 2 hrs to fix

          Function animateScroll has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  smoothScroll.animateScroll = function (anchor, toggle, options) {

            // Local settings
            var animateSettings = extend(settings || defaults, options || {}); // Merge user options with defaults
          Severity: Minor
          Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 1 hr to fix

            Function escapeCharacters has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var escapeCharacters = function (id) {

        // Remove leading hash
        if (id.charAt(0) === '#') {
            id = id.substr(1);
            Severity: Minor
            Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                          if (
                codeUnit >= 0x0080 ||
                codeUnit === 0x002D ||
                codeUnit === 0x005F ||
                codeUnit >= 0x0030 && codeUnit <= 0x0039 ||
              Severity: Critical
              Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  config.wrappers :inline_form, tag: 'div', class: 'form-group', error_class: 'has-error' do |b|
    b.use :html5
    b.use :placeholder
    b.optional :maxlength
    b.optional :pattern
                Severity: Major
                Found in tramway-conference/config/initializers/simple_form_bootstrap.rb and 1 other location - About 1 hr to fix
                tramway-conference/config/initializers/simple_form_bootstrap.rb on lines 8..20

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  config.wrappers :vertical_form, tag: 'div', class: 'form-group', error_class: 'has-error' do |b|
    b.use :html5
    b.use :placeholder
    b.optional :maxlength
    b.optional :pattern
                Severity: Major
                Found in tramway-conference/config/initializers/simple_form_bootstrap.rb and 1 other location - About 1 hr to fix
                tramway-conference/config/initializers/simple_form_bootstrap.rb on lines 112..124

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def set_singleton_models(*models, project:, role: :open)
    @singleton_models ||= {}
    @singleton_models[project] ||= {}
    @singleton_models[project][role] ||= {}
    models.each do |model|
                Severity: Major
                Found in tramway-api/lib/tramway/api/singleton_models.rb and 1 other location - About 1 hr to fix
                tramway-api/lib/tramway/api/records_models.rb on lines 4..15

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def set_available_models(*models, project:, role: :open)
    @available_models ||= {}
    @available_models[project] ||= {}
    @available_models[project][role] ||= {}
    models.each do |model|
                Severity: Major
                Found in tramway-api/lib/tramway/api/records_models.rb and 1 other location - About 1 hr to fix
                tramway-api/lib/tramway/api/singleton_models.rb on lines 4..15

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function clickHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        var clickHandler = function (event) {

            // Don't run if the user prefers reduced motion
            if (reduceMotion(settings)) return;
                Severity: Minor
                Found in tramway-landing/app/assets/javascripts/tramway/landing/smooth-scroll.js - About 1 hr to fix

                  Method record has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def record
          if params[:key].present?
            if Tramway::Api.other_id_methods_of(model: model_class).include? params[:key].to_sym
              @record = model_class.find_by! params[:key] => params[:id] if params[:id].present?
            end
                  Severity: Minor
                  Found in tramway-api/app/controllers/tramway/api/v1/application_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method error_messages has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def error_messages(object, path = []) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
    error_messages = {}

    if object.respond_to? :errors
      object.errors.messages.each do |name, messages|
                  Severity: Minor
                  Found in tramway-api/app/serializers/tramway/api/v1/error_serializer.rb - About 1 hr to fix

                    Method action_is_available has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def action_is_available(project:, role: :open, model_name:, action:, current_user: nil)
        actions = select_actions(project: project, role: role, model_name: model_name)
        if actions.present? && !actions.is_a?(Array)
          raise "Looks like you did not used array type to define action permissions. Remember it should be this way: `#{model_name} => [ :#{action} ]` or `#{model_name} => [ { #{action}: lambda { |record, current_user| your_condition } } ]`"
        end
                    Severity: Minor
                    Found in tramway-api/lib/tramway/api.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                                if( i === images.length - 1 ){
                                currentDiff = diff - adjustedDiff;
                            }
                    Severity: Major
                    Found in tramway-landing/app/assets/javascripts/justified_images.js - About 45 mins to fix

                      Method error_messages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def error_messages(object, path = []) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
    error_messages = {}

    if object.respond_to? :errors
      object.errors.messages.each do |name, messages|
                      Severity: Minor
                      Found in tramway-api/app/serializers/tramway/api/v1/error_serializer.rb - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      module Tramway::News::Generators
  class InstallGenerator < ::Tramway::Generators::InstallGenerator
    include Rails::Generators::Migration
    source_root File.expand_path('templates', __dir__)
                      Severity: Minor
                      Found in tramway-news/lib/tramway/news/generators/install_generator.rb and 1 other location - About 40 mins to fix
                      tramway-profiles/lib/tramway/profiles/generates/install_generator.rb on lines 6..19

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 37.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language