Sign upLogin

unageanu/jiji2

View on GitHub
Star
sample_agents/spec/range_break_checker_spec.rb

Summary

Maintainability
F
4 days
Test Coverage

Block has too many lines. [347/25]
Open

describe RangeBreakChecker do
  include_context 'use agent_setting'

  let(:pairs) do
    [
Severity: Minor
Found in sample_agents/spec/range_break_checker_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [105/25]
Open

  it 'レートがrange_pips外になっても、' \
     '外れたところからrange_periodの期間が過ぎればブレイクする' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    result = checker.check_range_break(Jiji::Model::Trading::Tick.new({
Severity: Minor
Found in sample_agents/spec/range_break_checker_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [74/25]
Open

  it '状態を永続化して復元できる' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    # データが不足している状態では ブレイクしない
    result = checker.check_range_break(Jiji::Model::Trading::Tick.new({
Severity: Minor
Found in sample_agents/spec/range_break_checker_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

File range_break_checker_spec.rb has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sample_agent_test_configuration'

describe RangeBreakChecker do
  include_context 'use agent_setting'
Severity: Minor
Found in sample_agents/spec/range_break_checker_spec.rb - About 4 hrs to fix

    Block has too many lines. [69/25]
    Open

      it 'periodの期間、レートがrange_pipsで推移した後、'\
     '上に抜けるとレンジブレイクする' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    # データが不足している状態では ブレイクしない
    Severity: Minor
    Found in sample_agents/spec/range_break_checker_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Block has too many lines. [69/25]
    Open

      it 'periodの期間、レートがrange_pipsで推移した後、'\
     '下に抜けるとレンジブレイクする' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    # データが不足している状態では ブレイクしない
    Severity: Minor
    Found in sample_agents/spec/range_break_checker_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it 'periodの期間、レートがrange_pipsで推移した後、'\
     '下に抜けるとレンジブレイクする' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    # データが不足している状態では ブレイクしない
    Severity: Major
    Found in sample_agents/spec/range_break_checker_spec.rb and 1 other location - About 1 day to fix
    sample_agents/spec/range_break_checker_spec.rb on lines 17..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 456.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it 'periodの期間、レートがrange_pipsで推移した後、'\
     '上に抜けるとレンジブレイクする' do
    checker = RangeBreakChecker.new(pairs[0], 60 * 8, 100)

    # データが不足している状態では ブレイクしない
    Severity: Major
    Found in sample_agents/spec/range_break_checker_spec.rb and 1 other location - About 1 day to fix
    sample_agents/spec/range_break_checker_spec.rb on lines 111..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 456.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      let(:pairs) do
    [
      Jiji::Model::Trading::Pair.new(
        :USDJPY, 'USD_JPY', 0.01,   10_000_000, 0.001,   0.04),
      Jiji::Model::Trading::Pair.new(
    Severity: Minor
    Found in sample_agents/spec/range_break_checker_spec.rb and 1 other location - About 15 mins to fix
    sample_agents/spec/trailing_stop_manager_spec.rb on lines 27..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status