Sign upLogin

unageanu/jiji2

View on GitHub
Star
sample_agents/spec/trap_repeat_if_done_spec.rb

Summary

Maintainability
F
2 wks
Test Coverage

Block has too many lines. [596/25]
Open

describe TrapRepeatIfDone do
  include_context 'use agent_setting'

  let(:position_repository) { container.lookup(:position_repository) }
  let(:backtest) { backtests[0] }
Severity: Minor
Found in sample_agents/spec/trap_repeat_if_done_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [261/25]
Open

  describe 'EURUSD/売りモードの場合' do
    let(:logic) do
      TrapRepeatIfDone.new(pairs[1], :sell, 55, 8, 103, Logger.new(STDOUT))
    end
Severity: Minor
Found in sample_agents/spec/trap_repeat_if_done_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [261/25]
Open

  describe 'EURJPY/買モードの場合' do
    let(:logic) do
      TrapRepeatIfDone.new(pairs[0], :buy, 40, 10, 80, Logger.new(STDOUT))
    end
Severity: Minor
Found in sample_agents/spec/trap_repeat_if_done_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [256/25]
Open

    it '注文を登録できる' do
      mock_securities.seeds = [0, 0.003, 0.0045, 0.0056]

      logic.register_orders(broker)
Severity: Minor
Found in sample_agents/spec/trap_repeat_if_done_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [256/25]
Open

    it '注文を登録できる' do
      mock_securities.seeds = [0, 0.25, 0.41, 0.5]

      logic.register_orders(broker)
Severity: Minor
Found in sample_agents/spec/trap_repeat_if_done_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

File trap_repeat_if_done_spec.rb has 599 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sample_agent_test_configuration'

describe TrapRepeatIfDone do
  include_context 'use agent_setting'
Severity: Major
Found in sample_agents/spec/trap_repeat_if_done_spec.rb - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      describe 'EURJPY/買モードの場合' do
    let(:logic) do
      TrapRepeatIfDone.new(pairs[0], :buy, 40, 10, 80, Logger.new(STDOUT))
    end
    Severity: Major
    Found in sample_agents/spec/trap_repeat_if_done_spec.rb and 1 other location - About 6 days to fix
    sample_agents/spec/trap_repeat_if_done_spec.rb on lines 376..679

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1544.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      describe 'EURUSD/売りモードの場合' do
    let(:logic) do
      TrapRepeatIfDone.new(pairs[1], :sell, 55, 8, 103, Logger.new(STDOUT))
    end
    Severity: Major
    Found in sample_agents/spec/trap_repeat_if_done_spec.rb and 1 other location - About 6 days to fix
    sample_agents/spec/trap_repeat_if_done_spec.rb on lines 68..371

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1544.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status