Sign upLogin

unageanu/jiji2

View on GitHub
Star
sample_agents/src/bollinger_bands_agent.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method initialize has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(pair, units, distance, broker,
      index_graph = nil, bands_graph = nil, logger = nil,
      calculator = BollingerBandsCalculator.new)
Severity: Major
Found in sample_agents/src/bollinger_bands_agent.rb - About 1 hr to fix

    Use each_key instead of keys.each.
    Open

          @positions.keys.each do |key|
    Severity: Minor
    Found in sample_agents/src/bollinger_bands_agent.rb by rubocop

    This cop checks for uses of each_key and each_value Hash methods.

    Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

    Example:

    # bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def sample_variance(array)
      m = mean(array)
      sum = array.inject(0) { |a, e| a + (e - m)**2 }
      sum / (array.length - 1).to_f
    Severity: Minor
    Found in sample_agents/src/bollinger_bands_agent.rb and 1 other location - About 15 mins to fix
    sample_agents/src/statistical_arbitrage_agent.rb on lines 118..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status