unepwcmc/SAPI

View on GitHub
app/helpers/admin_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method admin_new_modal has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def admin_new_modal(options = {})
    resource = options[:resource] || controller_name.singularize
    id = options[:id] || "new-#{resource}"
    title = options[:title] || "Add new #{resource.titleize}"
    content_tag(
Severity: Minor
Found in app/helpers/admin_helper.rb - About 1 hr to fix

    Method admin_new_modal has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def admin_new_modal(options = {})
        resource = options[:resource] || controller_name.singularize
        id = options[:id] || "new-#{resource}"
        title = options[:title] || "Add new #{resource.titleize}"
        content_tag(
    Severity: Minor
    Found in app/helpers/admin_helper.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ancestors_path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def ancestors_path(taxon_concept)
        Rank.where(
          ["taxonomic_position < ?", taxon_concept.rank.taxonomic_position]
          ).order(:taxonomic_position).map do |r|
          return nil unless taxon_concept.data
    Severity: Minor
    Found in app/helpers/admin_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status