Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
app/models/listing_change.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method listing_change_before_save_callback has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def listing_change_before_save_callback
    # check if annotation should be deleted
    if annotation &&
       annotation.short_note_en.blank? &&
       annotation.short_note_fr.blank? &&
Severity: Minor
Found in app/models/listing_change.rb - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        if annotation &&
       annotation.short_note_en.blank? &&
       annotation.short_note_fr.blank? &&
       annotation.short_note_es.blank? &&
       annotation.full_note_en.blank? &&
    Severity: Major
    Found in app/models/listing_change.rb - About 1 hr to fix

      Method listing_change_before_save_callback has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def listing_change_before_save_callback
    # check if annotation should be deleted
    if annotation &&
       annotation.short_note_en.blank? &&
       annotation.short_note_fr.blank? &&
      Severity: Minor
      Found in app/models/listing_change.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status