Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
app/models/trade/validation_rule.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method shipment_in_scope? has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def shipment_in_scope?(shipment)
    shipment_in_scope = true
    # check if shipment is in scope of this validation
    sanitized_shipments_scope.each do |scope_column, scope_def|
      value = shipment.send(scope_column)
Severity: Minor
Found in app/models/trade/validation_rule.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanitized_shipments_scope has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sanitized_shipments_scope
    res = {}
    sanitized_sandbox_scope.each do |scope_column, scope_def|
      case scope_column
      when 'taxon_name', 'rank'
Severity: Minor
Found in app/models/trade/validation_rule.rb - About 1 hr to fix

    Method sanitized_shipments_scope has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def sanitized_shipments_scope
    res = {}
    sanitized_sandbox_scope.each do |scope_column, scope_def|
      case scope_column
      when 'taxon_name', 'rank'
    Severity: Minor
    Found in app/models/trade/validation_rule.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_or_create_error_record has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def update_or_create_error_record(annual_report_upload, existing_record, error_count, error_message, matching_criteria)
    Severity: Minor
    Found in app/models/trade/validation_rule.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status