Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
app/serializers/species/show_taxon_concept_serializer_cites.rb

Summary

Maintainability
D
2 days
Test Coverage

File show_taxon_concept_serializer_cites.rb has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Species::ShowTaxonConceptSerializerCites < Species::ShowTaxonConceptSerializer

  attributes :cites_listing, :eu_listing
  has_many :quotas, :serializer => Species::QuotaSerializer, :key => :cites_quotas
  has_many :cites_suspensions, :serializer => Species::CitesSuspensionSerializer
Severity: Minor
Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 4 hrs to fix

    Method cites_listing_changes has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def cites_listing_changes
    rel = MCitesListingChange.from('api_cites_listing_changes_view AS listing_changes_mview').
      where(
        'listing_changes_mview.taxon_concept_id' => object_and_children
      )
    Severity: Major
    Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 2 hrs to fix

      Method eu_listing_changes has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def eu_listing_changes
    rel = MEuListingChange.from('api_eu_listing_changes_view AS listing_changes_mview').
      where(
        'listing_changes_mview.taxon_concept_id' => object_and_children
      )
      Severity: Major
      Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 2 hrs to fix

        Method cites_suspensions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cites_suspensions
    CitesSuspension.from('api_cites_suspensions_view AS trade_restrictions').
      where("
            trade_restrictions.taxon_concept_id IN (:object_and_children)
            OR (
        Severity: Minor
        Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 1 hr to fix

          Method quotas has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def quotas
    Quota.from('api_cites_quotas_view AS trade_restrictions').
      where("
            trade_restrictions.taxon_concept_id IN (:object_and_children)
            OR (
          Severity: Minor
          Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 1 hr to fix

            Method eu_decision_select_attrs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def eu_decision_select_attrs
    string = %{
            eu_decisions.notes,
            eu_decisions.start_date,
            v.original_start_date_formatted,
            Severity: Minor
            Found in app/serializers/species/show_taxon_concept_serializer_cites.rb - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def cites_listing_changes
    rel = MCitesListingChange.from('api_cites_listing_changes_view AS listing_changes_mview').
      where(
        'listing_changes_mview.taxon_concept_id' => object_and_children
      )
              Severity: Major
              Found in app/serializers/species/show_taxon_concept_serializer_cites.rb and 1 other location - About 1 hr to fix
              app/serializers/species/show_taxon_concept_serializer_cites.rb on lines 268..325

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def eu_listing_changes
    rel = MEuListingChange.from('api_eu_listing_changes_view AS listing_changes_mview').
      where(
        'listing_changes_mview.taxon_concept_id' => object_and_children
      )
              Severity: Major
              Found in app/serializers/species/show_taxon_concept_serializer_cites.rb and 1 other location - About 1 hr to fix
              app/serializers/species/show_taxon_concept_serializer_cites.rb on lines 199..257

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def quotas
    Quota.from('api_cites_quotas_view AS trade_restrictions').
      where("
            trade_restrictions.taxon_concept_id IN (:object_and_children)
            OR (
              Severity: Minor
              Found in app/serializers/species/show_taxon_concept_serializer_cites.rb and 1 other location - About 15 mins to fix
              app/serializers/species/show_taxon_concept_serializer_cites.rb on lines 90..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def cites_suspensions
    CitesSuspension.from('api_cites_suspensions_view AS trade_restrictions').
      where("
            trade_restrictions.taxon_concept_id IN (:object_and_children)
            OR (
              Severity: Minor
              Found in app/serializers/species/show_taxon_concept_serializer_cites.rb and 1 other location - About 15 mins to fix
              app/serializers/species/show_taxon_concept_serializer_cites.rb on lines 45..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status