Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
app/services/checklist/checklist.rb

Summary

Maintainability
C
1 day
Test Coverage

Method summarise_filters has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  def self.summarise_filters(params)
    summary = []

    options = Checklist::ChecklistParams.sanitize(params)
    options.keys.each { |k| instance_variable_set("@#{k}", options[k]) }
Severity: Minor
Found in app/services/checklist/checklist.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method summarise_filters has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.summarise_filters(params)
    summary = []

    options = Checklist::ChecklistParams.sanitize(params)
    options.keys.each { |k| instance_variable_set("@#{k}", options[k]) }
Severity: Major
Found in app/services/checklist/checklist.rb - About 2 hrs to fix

    Method initialize_query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize_query
    @taxon_concepts_rel = MTaxonConcept.all.
      by_cites_eu_taxonomy

    if @cites_regions.empty? && @countries.empty? && !@cites_appendices.empty?
    Severity: Minor
    Found in app/services/checklist/checklist.rb - About 1 hr to fix

      Method initialize_query has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize_query
    @taxon_concepts_rel = MTaxonConcept.all.
      by_cites_eu_taxonomy

    if @cites_regions.empty? && @countries.empty? && !@cites_appendices.empty?
      Severity: Minor
      Found in app/services/checklist/checklist.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status