app/services/document_search.rb
Class DocumentSearch
has 27 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class DocumentSearch
# NOTE!!! This class returns an unpaginated result. Not sure if pagination can be restored
# and it is currently being done on the unpaginated query results in the API and web
# documents #index endpoints.
include CacheIterator
Method add_conditions_for_document
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def add_conditions_for_document
@query = @query.search_by_title(@title_query) if @title_query.present?
if @document_type.present?
@query = @query.where('document_type IN (?)', @document_type.split(','))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"