Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
app/services/nomenclature_change/reassignment_summarizer.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method summary has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def summary
    [
      output_children_summary,
      output_names_summary,
      output_distribution_summary,
Severity: Minor
Found in app/services/nomenclature_change/reassignment_summarizer.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def output_generic_summary(rel, reassignable_type, title)
    objects_cnt = rel.count
    return nil unless objects_cnt > 0
    cnt = @input.reassignments.includes(:reassignment_targets).
      where(
    Severity: Minor
    Found in app/services/nomenclature_change/reassignment_summarizer.rb and 1 other location - About 55 mins to fix
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 110..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def output_legislation_summary(rel, reassignable_type, title)
    objects_cnt = rel.count
    return nil unless objects_cnt > 0
    cnt = @input.legislation_reassignments.includes(:reassignment_targets).
      where(
    Severity: Minor
    Found in app/services/nomenclature_change/reassignment_summarizer.rb and 1 other location - About 55 mins to fix
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 120..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def output_children_summary
    children_cnt = @input.taxon_concept.children.count
    return nil unless children_cnt > 0
    cnt =
      if @input.is_a?(NomenclatureChange::Output)
    Severity: Minor
    Found in app/services/nomenclature_change/reassignment_summarizer.rb and 2 other locations - About 40 mins to fix
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 80..92
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 95..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def output_distribution_summary
    distributions_cnt = @input.taxon_concept.distributions.count
    return nil unless distributions_cnt > 0
    cnt =
      if @input.is_a?(NomenclatureChange::Output)
    Severity: Minor
    Found in app/services/nomenclature_change/reassignment_summarizer.rb and 2 other locations - About 40 mins to fix
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 47..59
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 95..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def output_documents_summary
    document_citations_cnt = @input.taxon_concept.document_citation_taxon_concepts.count
    return nil unless document_citations_cnt > 0
    cnt =
      if @input.is_a?(NomenclatureChange::Output)
    Severity: Minor
    Found in app/services/nomenclature_change/reassignment_summarizer.rb and 2 other locations - About 40 mins to fix
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 47..59
    app/services/nomenclature_change/reassignment_summarizer.rb on lines 80..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status