Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
lib/tasks/elibrary/citations_importer.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method run_queries has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_queries
    ApplicationRecord.connection.execute('DROP TABLE IF EXISTS elibrary_citations_resolved_tmp')
    ApplicationRecord.connection.execute('CREATE TABLE elibrary_citations_resolved_tmp (document_id INT, CitationId INT, CtyISO2 TEXT, splus_taxon_concept_id INT)')
    ApplicationRecord.connection.execute(
      <<-SQL
Severity: Major
Found in lib/tasks/elibrary/citations_importer.rb - About 2 hrs to fix

    Method columns_with_type has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def columns_with_type
    [
      ['EventTypeID', 'TEXT'],
      ['EventTypeName', 'TEXT'],
      ['splus_event_type', 'TEXT'],
    Severity: Minor
    Found in lib/tasks/elibrary/citations_importer.rb - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        def print_breakdown
    puts "#{Time.now} There are #{DocumentCitation.count} citations in total"
    DocumentCitation.includes(:document).group('documents.type').order('documents.type').count.each do |type, count|
      puts "\t #{type} #{count}"
      Severity: Minor
      Found in lib/tasks/elibrary/citations_importer.rb and 1 other location - About 25 mins to fix
      lib/tasks/elibrary/citations_manual_importer.rb on lines 122..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status