Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
lib/tasks/elibrary/documents_identification_importer.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method run_queries has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_queries
    # insert master documents
    sql = <<-SQL
      WITH rows_to_insert AS (
        #{rows_to_insert_sql}
Severity: Major
Found in lib/tasks/elibrary/documents_identification_importer.rb - About 3 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      def print_breakdown
    puts "#{Time.now} There are #{Document.count} documents in total"
    Document.group(:type).order(:type).count.each do |type, count|
      puts "\t #{type} #{count}"
    Severity: Minor
    Found in lib/tasks/elibrary/documents_identification_importer.rb and 3 other locations - About 20 mins to fix
    lib/tasks/elibrary/documents_importer.rb on lines 170..173
    lib/tasks/elibrary/events_importer.rb on lines 132..135
    lib/tasks/elibrary/users_importer.rb on lines 99..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status