Sign upLogin

unepwcmc/SAPI

View on GitHub
Star
lib/tasks/helpers_for_import.rb

Summary

Maintainability
C
1 day
Test Coverage

File helpers_for_import.rb has 485 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'csv'

class CsvToDbMap
  include Singleton
Severity: Minor
Found in lib/tasks/helpers_for_import.rb - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def copy_data_into_table(path_to_file, table_name, db_columns)
  require 'psql_command'
  puts "Copying data from #{path_to_file} into tmp table #{table_name}"
  cmd = <<-PSQL
SET DateStyle = \"ISO,DMY\";
    Severity: Minor
    Found in lib/tasks/helpers_for_import.rb and 1 other location - About 30 mins to fix
    lib/tasks/elibrary/importable.rb on lines 29..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'eu_decisions_import' => {
      'IsCurrent?' => 'is_current boolean',
      'Taxonomy' => 'taxonomy varchar',
      'LawID' => 'event_legacy_id integer',
      'SpcRecID' => 'legacy_id integer',
    Severity: Minor
    Found in lib/tasks/helpers_for_import.rb and 1 other location - About 20 mins to fix
    lib/tasks/helpers_for_import.rb on lines 295..308

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'eu_opinions_import' => {
      'taxon_concept_id' => 'taxon_concept_id integer',
      'start_regulation_name' => 'start_event_name varchar',
      'country_name' => 'country_name varchar',
      'start_date' => 'start_date date',
    Severity: Minor
    Found in lib/tasks/helpers_for_import.rb and 1 other location - About 20 mins to fix
    lib/tasks/helpers_for_import.rb on lines 280..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status