Sign upLogin

uniak/puppet-networkdevice

View on GitHub
Star

Showing 98 of 98 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def archive(name)
    unless params[:archive]
      params[:archive] = Puppet::Util::NetworkDevice::Cisco_ios::Model::Archive.new(transport, facts, { :name => name })
      params[:archive].evaluate_new_params
    end
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/switch.rb and 1 other location - About 25 mins to fix
lib/puppet/util/network_device/cisco_ios/model/switch.rb on lines 80..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def snmp(name)
    unless params[:snmp]
      params[:snmp] = Puppet::Util::NetworkDevice::Cisco_ios::Model::Snmp.new(transport, facts, {:name => name})
      params[:snmp].evaluate_new_params
    end
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/switch.rb and 1 other location - About 25 mins to fix
lib/puppet/util/network_device/cisco_ios/model/switch.rb on lines 88..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method extract_scope has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def extract_scope(txt)
    raise "No scope_name configured" if @scope_name.nil?
    return if txt.nil? || txt.empty?

    munged = txt.scan(scope).collect do |content,name|
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/scoped_value.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register_new_module has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def register_new_module(mod, path_addition = "")
    @included_modules ||= []
    unless @included_modules.include?(mod)
      Puppet::Util::Autoload.new(self, File.join(mod_path_base, path_addition), :wrap => false).load(mod)
      if path_addition.empty?
Severity: Minor
Found in lib/puppet/util/network_device/dsl.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method change_to_s has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def change_to_s(current_value, newvalue)
        begin
          if current_value == :absent
            return "defined '#{name}' as #{self.class.format_value_for_display should_to_s(newvalue)}"
          elsif newvalue == :absent
Severity: Minor
Found in lib/puppet/util/ip_prop.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def expect(prompt)
      lines = ''
      @telnet.waitfor(prompt) do |out|
        lines << out.gsub(/\r\n/no, "\n")
        yield out if block_given?
Severity: Minor
Found in lib/puppet/util/network_device/transport_ios/telnet.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    ifprop(base, :dhcp_snooping_trust) do
      match do |txt|
        txt.match(/^\s*ip dhcp snooping trust\s*$/) ? :present : :absent
      end
      add do |transport, _|
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/interface/base.rb and 3 other locations - About 15 mins to fix
lib/puppet/util/network_device/cisco_ios/model/archive/base.rb on lines 27..35
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 58..66
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 74..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    snmp_prop(base, :manager) do
      match do |txt|
        txt.match(/^snmp-server manager$/) ? :present : :absent
      end
      add do |transport, _|
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb and 3 other locations - About 15 mins to fix
lib/puppet/util/network_device/cisco_ios/model/archive/base.rb on lines 27..35
lib/puppet/util/network_device/cisco_ios/model/interface/base.rb on lines 127..135
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 74..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    archive_prop(base, :write_memory) do
      match do |txt|
        txt.match(/write-memory/) ? :present : :absent
      end
      add do |transport, _|
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/archive/base.rb and 3 other locations - About 15 mins to fix
lib/puppet/util/network_device/cisco_ios/model/interface/base.rb on lines 127..135
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 58..66
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 74..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    snmp_prop(base, :system_shutdown) do
      match do |txt|
        txt.match(/^snmp-server system-shutdown$/) ? :present : :absent
      end
      add do |transport, _|
Severity: Minor
Found in lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb and 3 other locations - About 15 mins to fix
lib/puppet/util/network_device/cisco_ios/model/archive/base.rb on lines 27..35
lib/puppet/util/network_device/cisco_ios/model/interface/base.rb on lines 127..135
lib/puppet/util/network_device/cisco_ios/model/snmp/base.rb on lines 58..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:udp_port) do
    desc "The notification host's UDP port number (default port 162)"
    newvalues(:absent, /^\d+$/)
    validate do |value|
      self.fail "'snmp-server host * * udp-port' must be between 0-65535" unless value.to_i <= 65535 && value.to_i >= 0
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server_host.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 76..81
lib/puppet/type/cisco_snmp_server.rb on lines 84..89
lib/puppet/type/cisco_snmp_server.rb on lines 92..97
lib/puppet/type/cisco_snmp_server.rb on lines 100..105
lib/puppet/type/cisco_snmp_server.rb on lines 108..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:inform_timeout) do
    desc "Set timeout for informs"
    newvalues(:absent, /\d+/)
    validate do |value|
      self.fail "'snmp-server inform timeout' must be between 1-4294967295" unless value.to_i <= 4294967295 && value.to_i >= 1
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 76..81
lib/puppet/type/cisco_snmp_server.rb on lines 84..89
lib/puppet/type/cisco_snmp_server.rb on lines 100..105
lib/puppet/type/cisco_snmp_server.rb on lines 108..113
lib/puppet/type/cisco_snmp_server_host.rb on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def insync?(is)
      return ([is].flatten.sort == [@should].flatten.sort || [is].flatten.sort == [@should].flatten.map(&:to_s).sort)
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 1 other location - About 15 mins to fix
lib/puppet/type/cisco_config.rb on lines 220..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:ip_precedence) do
    desc "IP Precedence value for SNMP traffic"
    newvalues(:absent, /\d+/)
    validate do |value|
      self.fail "'snmp-server ip precedence' must be between 0-7" unless value.to_i <= 7 && value.to_i > 0
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 76..81
lib/puppet/type/cisco_snmp_server.rb on lines 84..89
lib/puppet/type/cisco_snmp_server.rb on lines 92..97
lib/puppet/type/cisco_snmp_server.rb on lines 100..105
lib/puppet/type/cisco_snmp_server_host.rb on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:inform_pending) do
    desc "Set number of unacked informs to hold"
    newvalues(:absent, /\d+/)
    validate do |value|
      self.fail "'snmp-server inform pending' must be between 1-4294967295" unless value.to_i <= 4294967295 && value.to_i >= 1
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 84..89
lib/puppet/type/cisco_snmp_server.rb on lines 92..97
lib/puppet/type/cisco_snmp_server.rb on lines 100..105
lib/puppet/type/cisco_snmp_server.rb on lines 108..113
lib/puppet/type/cisco_snmp_server_host.rb on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:ip_dscp) do
    desc "IP DSCP value for SNMP traffic"
    newvalues(:absent, /\d+/)
    validate do |value|
      self.fail "'snmp-server ip dscp' must be between 0-63" unless value.to_i <= 63 && value.to_i > 0
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 76..81
lib/puppet/type/cisco_snmp_server.rb on lines 84..89
lib/puppet/type/cisco_snmp_server.rb on lines 92..97
lib/puppet/type/cisco_snmp_server.rb on lines 108..113
lib/puppet/type/cisco_snmp_server_host.rb on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def insync?(is)
      return ([is].flatten.sort == [@should].flatten.sort || [is].flatten.sort == [@should].flatten.map(&:to_s).sort)
Severity: Minor
Found in lib/puppet/type/cisco_config.rb and 1 other location - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 47..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  newproperty(:inform_retries) do
    desc "Set retry count for informs"
    newvalues(:absent, /\d+/)
    validate do |value|
      self.fail "'snmp-server inform retries' must be between 1-100" unless value.to_i <= 100 && value.to_i >= 1
Severity: Minor
Found in lib/puppet/type/cisco_snmp_server.rb and 5 other locations - About 15 mins to fix
lib/puppet/type/cisco_snmp_server.rb on lines 76..81
lib/puppet/type/cisco_snmp_server.rb on lines 92..97
lib/puppet/type/cisco_snmp_server.rb on lines 100..105
lib/puppet/type/cisco_snmp_server.rb on lines 108..113
lib/puppet/type/cisco_snmp_server_host.rb on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language