Sign upLogin

unicef/magicbox-maps

View on GitHub
Star

Showing 48 of 48 total issues

Function selectCountry has 120 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const selectCountry = (country, sliderVal, country_data_path) => {
  console.log('You selected', country);
  if (mode !== 'schools') {
    return function(dispatch) {
      dispatch({type: 'REQUEST_DATA'})
Severity: Major
Found in react-app/src/actions/action-select-country.js - About 4 hrs to fix

Function render has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const gif_style = {width: '300px'}
    const grid_style = {width: '700px'}
    if (isBrowser) {
      return (
Severity: Major
Found in react-app/src/components/ModalContentMobility.jsx - About 3 hrs to fix

Function render has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    console.log(this.props.activeCountry.usingSpeed);

    let data = {
      labels: [
Severity: Major
Found in react-app/src/components/Dock.js - About 3 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                <ul style={ul_style}>
                  <li>This map is sorted by administrative boundaries. Read more about administrative boundaries <a href="https://magicbox.readthedocs.io/en/latest/administrative-boundaries.html" target="_blank">here</a>.</li>
                  <li>Click on an administrative boundary to see traffic <em>from</em> that area <em>to</em> another. Click on multiple boundaries to see traffic from those areas collectively.</li>
                  <li>Blue regions are the areas you selected. The shaded red areas show the movement of people traveling to that area from where you selected.</li>
                </ul>
Severity: Major
Found in react-app/src/components/ModalContentMobility.jsx and 1 other location - About 2 hrs to fix
react-app/src/components/ModalContentMobility.jsx on lines 57..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                <ul>
                  <li>This map is sorted by administrative boundaries. Read more about administrative boundaries <a href="https://magicbox.readthedocs.io/en/latest/administrative-boundaries.html" target="_blank">here</a>.</li>
                  <li>Click on an administrative boundary to see traffic <em>from</em> that area <em>to</em> another. Click on multiple boundaries to see traffic from those areas collectively.</li>
                  <li>Blue regions are the areas you selected. The shaded red areas show the movement of people traveling to that area from where you selected.</li>
                </ul>
Severity: Major
Found in react-app/src/components/ModalContentMobility.jsx and 1 other location - About 2 hrs to fix
react-app/src/components/ModalContentMobility.jsx on lines 101..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function activeCountryReducer has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function activeCountryReducer(state = initial_state, action) {
  switch (action.type) {
    case 'COUNTRY_SELECTED':
      if (config.mode !== 'schools') {
        country_admins = action.payload
Severity: Major
Found in react-app/src/reducers/reducer-active-country.js - About 2 hrs to fix

Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const style = {
      position: 'relative',
      top: '200px'
    }
Severity: Minor
Found in react-app/src/components/MyMap.jsx - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export default function(state = initialstate, action) {
  switch (action.type) {
  case 'OPEN_DOCK':
    return Object.assign({}, state, {
      display: true
Severity: Major
Found in react-app/src/reducers/reducer-dock.js and 1 other location - About 1 hr to fix
react-app/src/reducers/reducer-hover-button.js on lines 10..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export default function(state = initialstate, action) {
  switch (action.type) {
  case 'OPEN_DOCK':
    return Object.assign({}, state, {
      display: false
Severity: Major
Found in react-app/src/reducers/reducer-hover-button.js and 1 other location - About 1 hr to fix
react-app/src/reducers/reducer-dock.js on lines 10..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function activeCountryReducer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function activeCountryReducer(state = initial_state, action) {
  switch (action.type) {
    case 'COUNTRY_SELECTED':
      if (config.mode !== 'schools') {
        country_admins = action.payload
Severity: Minor
Found in react-app/src/reducers/reducer-active-country.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {isAuthenticated} = this.props.auth;
    return (
      <div>
        <Navbar fluid>
Severity: Minor
Found in react-app/src/authorization/Shield.js - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  axios.get(url)
    .catch(err => {
      console.log(err);
    })
    .then(response => {
Severity: Major
Found in routes/helper-router.js and 1 other location - About 1 hr to fix
routes/helper-router.js on lines 127..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  axios.get(url)
    .catch(err => {
      console.log(err);
    })
    .then(response => {
Severity: Major
Found in routes/helper-router.js and 1 other location - About 1 hr to fix
routes/helper-router.js on lines 112..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                <ul style={ul_style}>
                  <li>background on this particular app, please read <a href='https://medium.com/@mikefabrikant/the-project-f1f90c2a29b7'>this</a>.</li>
                  <li>an article that explains how mobility can be generated from cell phone usage, please read <a href='https://medium.com/@mikefabrikant/cell-towers-chiefdoms-and-anonymized-call-detail-records-a-guide-to-creating-a-mobility-matrix-d2d5c1bafb68'>this</a>.</li>
                </ul>
Severity: Major
Found in react-app/src/components/ModalContentMobility.jsx and 1 other location - About 1 hr to fix
react-app/src/components/ModalContentMobility.jsx on lines 43..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                <ul>
                  <li>background on this particular app, please read <a href='https://medium.com/@mikefabrikant/the-project-f1f90c2a29b7'>this</a>.</li>
                  <li>an article that explains how mobility can be generated from cell phone usage, please read <a href='https://medium.com/@mikefabrikant/cell-towers-chiefdoms-and-anonymized-call-detail-records-a-guide-to-creating-a-mobility-matrix-d2d5c1bafb68'>this</a>.</li>
                </ul>
Severity: Major
Found in react-app/src/components/ModalContentMobility.jsx and 1 other location - About 1 hr to fix
react-app/src/components/ModalContentMobility.jsx on lines 91..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function SliderChange has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

const SliderChange = function(geojson, sliderVal) {
  return function(dispatch) {
    let belowT = 0;
    let zeroT = 0;
    let aboveT = 0;
Severity: Minor
Found in react-app/src/actions/action-slider-change.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    let ModalContent = ModalContentSchools
    let email = config.email_contact_schools

    const style = {
Severity: Minor
Found in react-app/src/components/Popup.jsx - About 1 hr to fix

Function countryStyle has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function countryStyle(props) {
  return function(geoJsonFeature) {
    let activeCountry = props.activeCountry;
    const displayCountry = {
      fill: true,
Severity: Minor
Found in react-app/src/helpers/helper-countries-style.js - About 1 hr to fix

Function onEachCountryFeature has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function onEachCountryFeature(
  myMapObj,
  sliderVal,
  availableCountryPaths
) {
Severity: Minor
Found in react-app/src/helpers/helper-country-onEach.js - About 1 hr to fix

Function SliderChange has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const SliderChange = function(geojson, sliderVal) {
  return function(dispatch) {
    let belowT = 0;
    let zeroT = 0;
    let aboveT = 0;
Severity: Minor
Found in react-app/src/actions/action-slider-change.js - About 1 hr to fix
Severity
Category
Status
Source
Language