Sign upLogin

unicef/magicbox-open-api

View on GitHub
Star
api/helpers/general.js

Summary

Maintainability
D
2 days
Test Coverage

File general.js has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import config from '../../config'
import bluebird from 'bluebird'
import PostgresHelper from './postgres'
import * as data_access from '../../utils/data_access'
import fs from 'fs'
Severity: Minor
Found in api/helpers/general.js - About 7 hrs to fix

    Function getProperties has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const getProperties = (queryString) => {
  return new Promise((resolve, reject) => {
    let queryParts = queryString.split('_')
    let key = queryParts[0]
    let path = ''
    Severity: Major
    Found in api/helpers/general.js - About 3 hrs to fix

      Function getProperties has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      export const getProperties = (queryString) => {
  return new Promise((resolve, reject) => {
    let queryParts = queryString.split('_')
    let key = queryParts[0]
    let path = ''
      Severity: Minor
      Found in api/helpers/general.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mergePropertiesWithShapefile has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const mergePropertiesWithShapefile = (shapefileSet) => {
  return new Promise((resolve, reject) => {
    let {
      kind,
      source: dir,
      Severity: Minor
      Found in api/helpers/general.js - About 1 hr to fix

        Function value_map has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            let value_map = shapefile.reduce((ary, element) => {
      let tempList = Object.keys(element).filter(key => {
        return (key.startsWith('id_'))
      }).map(key => {
        return element[key]
        Severity: Minor
        Found in api/helpers/general.js - About 1 hr to fix

          Function countries_with_this_kind_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          export const countries_with_this_kind_data = (kind, source, country) => {
  return new Promise((resolve, reject) => {
    // Get country name for each shapefile
    getShapeFiles(kind, source)
      .then(shapefileSet => {
          Severity: Minor
          Found in api/helpers/general.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    fetchProperty(key, path, '_', 0)
          .then(propertyList => {
            let properties = {
              key: queryParts.join('_'),
              properties: propertyList
          Severity: Major
          Found in api/helpers/general.js and 3 other locations - About 1 hr to fix
          api/helpers/general.js on lines 450..457
          api/helpers/general.js on lines 487..494
          api/helpers/general.js on lines 503..510

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    fetchProperty(key, path, '.', 0)
          .then(propertyList => {
            let properties = {
              key: queryParts.join('_'),
              properties: propertyList
          Severity: Major
          Found in api/helpers/general.js and 3 other locations - About 1 hr to fix
          api/helpers/general.js on lines 450..457
          api/helpers/general.js on lines 470..477
          api/helpers/general.js on lines 487..494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    fetchProperty(key, path, '_', 0)
          .then(propertyList => {
            let properties = {
              key: queryParts.join('_'),
              properties: propertyList
          Severity: Major
          Found in api/helpers/general.js and 3 other locations - About 1 hr to fix
          api/helpers/general.js on lines 450..457
          api/helpers/general.js on lines 470..477
          api/helpers/general.js on lines 503..510

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    fetchProperty(key, path, '_', 0)
          .then(propertyList => {
            let properties = {
              key: queryParts.join('_'),
              properties: propertyList
          Severity: Major
          Found in api/helpers/general.js and 3 other locations - About 1 hr to fix
          api/helpers/general.js on lines 470..477
          api/helpers/general.js on lines 487..494
          api/helpers/general.js on lines 503..510

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status