Showing 106 of 106 total issues
The method sendResponse() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
Open
public function sendResponse(api\Response $response)
{
$protocol = (isset($_SERVER['SERVER_PROTOCOL']) ?
$_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0');
$body = null;- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The variable $_PUT is not named in camelCase. Open
Open
public function getRequest()
{
$request = new api\Request();
if (strpos($_SERVER['REQUEST_URI'], '?') === false) {
$request->parts = explode('/', $_SERVER['REQUEST_URI']);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_PUT is not named in camelCase. Open
Open
public function getRequest()
{
$request = new api\Request();
if (strpos($_SERVER['REQUEST_URI'], '?') === false) {
$request->parts = explode('/', $_SERVER['REQUEST_URI']);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
TODO found Open
Open
//TODO this needs to be different 2xx status based on what happened- Exclude checks
TODO found Open
Open
* TODO add order/group by support- Exclude checks
TODO found Open
Open
* TODO make this class more generic, not just for DB objects- Exclude checks