Sign upLogin

unix1/spoof

View on GitHub
Star
src/lib360/api/router/Rest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handleRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handleRequest(api\Request $request)
    {
        $response = new api\Response();
        try {
            // map request to class and method
Severity: Minor
Found in src/lib360/api/router/Rest.php - About 1 hr to fix

    Function handleRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handleRequest(api\Request $request)
    {
        $response = new api\Response();
        try {
            // map request to class and method
    Severity: Minor
    Found in src/lib360/api/router/Rest.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '171', column '23').
    Open

                throw new \BadMethodCallException("Method $operation is not implemented.");
    Severity: Minor
    Found in src/lib360/api/router/Rest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    TODO found
    Open

                //TODO this needs to be different 2xx status based on what happened
    Severity: Minor
    Found in src/lib360/api/router/Rest.php by fixme

    There are no issues that match your filters.

    Category
    Status