Sign upLogin

unix1/spoof

View on GitHub
Star
src/lib360/db/connection/Pool.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '49', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name already exists.");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method removeByName has a boolean flag argument $disconnect, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function removeByName($name, $disconnect = true)
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getByName has a boolean flag argument $connect, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getByName($name, $connect = true)
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '67', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name does not exist");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '89', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name does not exist.");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status