Sign upLogin

unix1/spoof

View on GitHub
Star
src/lib360/db/language/SQL.php

Summary

Maintainability
D
1 day
Test Coverage

File SQL.php has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *  This is Spoof.
 *  Copyright (C) 2011-2017  Spoof project.
Severity: Minor
Found in src/lib360/db/language/SQL.php - About 5 hrs to fix

    The class SQL has an overall complexity of 73 which is very high. The configured complexity threshold is 50.
    Open

    class SQL implements ILanguage
{
    const SELECT = 'select';
    const SELECT_AS = 'as';
    const SELECT_FIELD_SEPARATOR = ', ';
    Severity: Minor
    Found in src/lib360/db/language/SQL.php by phpmd

    Function getConditionOperator has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getConditionOperator(IDriver $driver, ICondition $condition)
    {
        switch ($condition->operator) {
            case Condition::OPERATOR_EQUALS:
                if ($condition->value2->getType() == Value::TYPE_NULL) {
    Severity: Minor
    Found in src/lib360/db/language/SQL.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getConditionOperator has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getConditionOperator(IDriver $driver, ICondition $condition)
    {
        switch ($condition->operator) {
            case Condition::OPERATOR_EQUALS:
                if ($condition->value2->getType() == Value::TYPE_NULL) {
    Severity: Minor
    Found in src/lib360/db/language/SQL.php - About 1 hr to fix

      Method getValue has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getValue(IDriver $driver, IValue $value)
    {
        $query = new Query();
        switch ($value->getType()) {
            case Value::TYPE_PREPARED:
      Severity: Minor
      Found in src/lib360/db/language/SQL.php - About 1 hr to fix

        Method getJoin has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getJoin(IDriver $driver, IJoin $join)
    {
        $query = new Query();
        $query->setString($driver->tableQuoteStart . $join->tableBase . $driver->tableQuoteEnd);
        foreach ($join->tableJoin as $i => $table) {
        Severity: Minor
        Found in src/lib360/db/language/SQL.php - About 1 hr to fix

          Function getValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getValue(IDriver $driver, IValue $value)
    {
        $query = new Query();
        switch ($value->getType()) {
            case Value::TYPE_PREPARED:
          Severity: Minor
          Found in src/lib360/db/language/SQL.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getSelectFromView has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getSelectFromView(IDriver $driver, IView $storage)
    {
        $query = new Query();
        $i = 0;
        foreach ($storage->joins as $key => $join) {
          Severity: Minor
          Found in src/lib360/db/language/SQL.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getJoin has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getJoin(IDriver $driver, IJoin $join)
    {
        $query = new Query();
        $query->setString($driver->tableQuoteStart . $join->tableBase . $driver->tableQuoteEnd);
        foreach ($join->tableJoin as $i => $table) {
          Severity: Minor
          Found in src/lib360/db/language/SQL.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method getValue() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
          Open

              public function getValue(IDriver $driver, IValue $value)
    {
        $query = new Query();
        switch ($value->getType()) {
            case Value::TYPE_PREPARED:
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method getConditionOperator() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

              public function getConditionOperator(IDriver $driver, ICondition $condition)
    {
        switch ($condition->operator) {
            case Condition::OPERATOR_EQUALS:
                if ($condition->value2->getType() == Value::TYPE_NULL) {
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The class SQL has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.
          Open

          class SQL implements ILanguage
{
    const SELECT = 'select';
    const SELECT_AS = 'as';
    const SELECT_FIELD_SEPARATOR = ', ';
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          Missing class import via use statement (line '194', column '23').
          Open

                      throw new \InvalidArgumentException(
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '230', column '27').
          Open

                          throw new \InvalidArgumentException(
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          The method getSelectFields uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            $fieldsString = self::SELECT_FIELDS_ALL;
        }
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method getConditionOperator uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                    $operator = self::CONDITION_NOT_EQUALS;
                }
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method getSelectFromView uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                      } else {
                throw new \InvalidArgumentException(
                    "View object join element at index $key must be an instance of \spoof\lib360\db\join\IJoin, \spoof\lib360\db\data\ITable, or string"
                );
            }
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method getSelectFieldFormatted uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            $field = $this->getFieldFormatted(
                    $driver,
                    $fieldKey
                ) . ' ' . self::SELECT_AS . ' ' . $driver->columnQuoteStart . $fieldValue . $driver->columnQuoteEnd;
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method getConditionOperator uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                    $operator = self::CONDITION_EQUALS;
                }
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method getSelectFrom uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            throw new \InvalidArgumentException(
                "Storage object of type \spoof\lib360\db\data\IView and \spoof\lib360\db\data\ITable expected, " . get_class(
                    $storage
                ) . " given."
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class '\spoof\lib360\crypt\Random' in method 'getValue'.
          Open

                          $tag = (string)Random::getString(4, true, true);
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid unused parameters such as '$driver'.
          Open

              public function getConditionOperator(IDriver $driver, ICondition $condition)
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$driver'.
          Open

              public function getConditionGroupOperator(IDriver $driver, $groupOperator)
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused local variables such as '$value'.
          Open

                  foreach ($data as $key => $value) {
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid variables with short names like $i. Configured minimum length is 3.
          Open

                  $i = 0;
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $i. Configured minimum length is 3.
          Open

                  $i = 0;
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $i. Configured minimum length is 3.
          Open

                  $i = 0;
          Severity: Minor
          Found in src/lib360/db/language/SQL.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          There are no issues that match your filters.

          Category
          Status