Sign upLogin

unrar/rmvc

View on GitHub
Star
lib/rmvc/core.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.create(projectname)
      puts "Creating new project: #{projectname}"
      puts ""
      # Check if directory exists
      if (File.directory? projectname) then
Severity: Major
Found in lib/rmvc/core.rb - About 2 hrs to fix

    Method generate has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.generate(args)
      # Check if we're in a RMVC project
      if (!File.directory? ".rmvc") then
        puts "error".red + "        Not a RMVC project! (missing directory .rmvc)"
        exit
    Severity: Minor
    Found in lib/rmvc/core.rb - About 1 hr to fix

      Method generate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.generate(args)
      # Check if we're in a RMVC project
      if (!File.directory? ".rmvc") then
        puts "error".red + "        Not a RMVC project! (missing directory .rmvc)"
        exit
      Severity: Minor
      Found in lib/rmvc/core.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

              if (File.exists? "app/migrations/#{args[2].downcase}.rb") then
          puts "error".red + "        File /app/migrations/#{args[2].downcase}.rb already exists."
          exit
        end
      Severity: Major
      Found in lib/rmvc/core.rb - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                puts "Generating view #{args[2]}..."
        # Create file /app/controllers/args[2]_controller.rb
        if (File.exists? "app/views/#{args[2].downcase}.rb") then
          puts "error".red + "        File /app/views/#{args[2].downcase}.rb already exists."
          exit
        Severity: Major
        Found in lib/rmvc/core.rb and 1 other location - About 1 hr to fix
        lib/rmvc/core.rb on lines 71..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                puts "Generating migration #{args[2]}..."
        # Create file /app/migrations/args[2].rb
        if (File.exists? "app/migrations/#{args[2].downcase}.rb") then
          puts "error".red + "        File /app/migrations/#{args[2].downcase}.rb already exists."
          exit
        Severity: Major
        Found in lib/rmvc/core.rb and 1 other location - About 1 hr to fix
        lib/rmvc/core.rb on lines 60..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status