unrealwork/atsd-api-nodejs

View on GitHub

Showing 33 of 33 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Entities.prototype.get = function(entity, callback) {
    var path = 'entities/' + entity;

    this.getRequest(path, {}, {}, function(error, response, body) {
        callback(error, response, body);
Severity: Major
Found in src/lib/entities.js and 1 other location - About 1 hr to fix
src/lib/entities.js on lines 94..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Entities.prototype.list = function(callback) {
    var path = entitiesPath;

    this.getRequest(path, {}, {}, function(error, response, body) {
        callback(error, response, body);
Severity: Major
Found in src/lib/entities.js and 1 other location - About 1 hr to fix
src/lib/metrics.js on lines 28..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Entities.prototype.delete = function(entity, callback) {
    var path = 'entities/' + entity;

    this.deleteRequest(path, {}, {}, function(error, response, body) {
        callback(error, response, body);
Severity: Major
Found in src/lib/entities.js and 1 other location - About 1 hr to fix
src/lib/entities.js on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function queryStatistic has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

Series.prototype.queryStatistic = function (metric, entity, tags, startTime, endTime, statistic, period, callback) {
Severity: Major
Found in src/lib/series.js - About 1 hr to fix

    Function methodTemplate has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function methodTemplate(method, entityGroup, isEntitiesEdit, params,
                            payload, callback, action) {
    Severity: Major
    Found in src/lib/entity-groups.js - About 50 mins to fix

      Function queryDetail has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Series.prototype.queryDetail = function (metric, entity, tags, startTime, endTime, callback) {
      Severity: Minor
      Found in src/lib/series.js - About 45 mins to fix

        Function request has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        HttpClient.prototype.request = function (method, path, params, payload, callback) {
        Severity: Minor
        Found in src/lib/client.js - About 35 mins to fix

          Function insertData has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          Series.prototype.insertData = function (metric, entity, tags, data, callback) {
          Severity: Minor
          Found in src/lib/series.js - About 35 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            HttpClient.prototype.patchRequest = function (path, params, payload, callback) {
                this.request(HttpClient.METHOD.PATCH, path, params, payload, callback);
            };
            Severity: Major
            Found in src/lib/client.js and 4 other locations - About 35 mins to fix
            src/lib/client.js on lines 80..82
            src/lib/client.js on lines 84..86
            src/lib/client.js on lines 88..90
            src/lib/client.js on lines 96..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            HttpClient.prototype.putRequest = function (path, params, payload, callback) {
                this.request(HttpClient.METHOD.PUT, path, params, payload, callback);
            };
            Severity: Major
            Found in src/lib/client.js and 4 other locations - About 35 mins to fix
            src/lib/client.js on lines 80..82
            src/lib/client.js on lines 84..86
            src/lib/client.js on lines 92..94
            src/lib/client.js on lines 96..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            HttpClient.prototype.getRequest = function (path, params, payload, callback) {
                this.request(HttpClient.METHOD.GET, path, params, payload, callback);
            };
            Severity: Major
            Found in src/lib/client.js and 4 other locations - About 35 mins to fix
            src/lib/client.js on lines 84..86
            src/lib/client.js on lines 88..90
            src/lib/client.js on lines 92..94
            src/lib/client.js on lines 96..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            HttpClient.prototype.deleteRequest = function (path, params, payload, callback) {
                this.request(HttpClient.METHOD.DELETE, path, params, payload, callback);
            };
            Severity: Major
            Found in src/lib/client.js and 4 other locations - About 35 mins to fix
            src/lib/client.js on lines 80..82
            src/lib/client.js on lines 84..86
            src/lib/client.js on lines 88..90
            src/lib/client.js on lines 92..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            HttpClient.prototype.postRequest = function (path, params, payload, callback) {
                this.request(HttpClient.METHOD.POST, path, params, payload, callback);
            };
            Severity: Major
            Found in src/lib/client.js and 4 other locations - About 35 mins to fix
            src/lib/client.js on lines 80..82
            src/lib/client.js on lines 88..90
            src/lib/client.js on lines 92..94
            src/lib/client.js on lines 96..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language