Sign upLogin

ursinn/DeadByDaylightMC

View on GitHub
Star

Showing 213 of 213 total issues

Method showArenaPage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Inventory showArenaPage(final DArena arena) {
        CustomHolder arenaInv = invBuilder.createNew(arena.getId(), 9);
        arenaInv.setIcon(8, closeMenu);
        Icon del = deleteItem.getCopy().clearLore();
        arenaInv.setIcon(7, del.addClickAction(p -> p.openInventory(confirmDelete(arena))));
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/ArenaManagmentInvs.java - About 1 hr to fix

Method blockInteract has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @EventHandler
    public void blockInteract(PlayerInteractEvent e) {

        DGame game = main.getGameManager().getGamePlayerIsIn(e.getPlayer());
        if (game != null && game.getStatus() == STATUS.INGAME) {
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/events/MainEvents.java - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (args[0].equalsIgnoreCase("create")) {
            if (args.length == 1) {
                player.sendMessage("Please provide an arena name(ID)");
                return true;
            }
Severity: Major
Found in src/main/java/noahnok/dbdl/files/commands/ArenaCommands.java and 1 other location - About 1 hr to fix
src/main/java/noahnok/dbdl/files/commands/ArenaCommands.java on lines 54..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (args[0].equalsIgnoreCase("delete")) {
            if (args.length == 1) {
                player.sendMessage("Please provide an arena name(ID)");
                return true;
            }
Severity: Major
Found in src/main/java/noahnok/dbdl/files/commands/ArenaCommands.java and 1 other location - About 1 hr to fix
src/main/java/noahnok/dbdl/files/commands/ArenaCommands.java on lines 32..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method endCountdown has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void endCountdown(boolean toPlay) {
        DSign sign = main.getSignManager().getSign(ref);
        if (sign != null) {
            sign.removeGame();
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/Countdown.java - About 1 hr to fix

Method addPlayerToMatchMakingLoop has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void addPlayerToMatchMakingLoop(final Player p, final String playType) {
        BukkitTask tryMatchMake = new BukkitRunnable() {
            public void run() {
                if (addToMatchmaking(p, playType)) {
                    removePlayerFromMatchMakingLoop(p);
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/MatchMaking.java - About 1 hr to fix

Method showArenaBlocks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void showArenaBlocks(final DArena a) {
        for (Location loc : a.getPossibleGeneratorLocations()) {
            addShulker(loc, BLUE, Material.FURNACE, a);
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/ArenaEditor.java - About 1 hr to fix

Method addToMatchmaking has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public boolean addToMatchmaking(Player p, String playType) {
        //Check if there are any available games
        if (waitingGames.isEmpty()) {
            //Try and create a new game
            DGame game = main.getGameManager().createNewGame();
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/MatchMaking.java - About 1 hr to fix

Method removeArenaBlock has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private boolean removeArenaBlock(DArena a, Location bloc) {
        if (a.getPossibleChestSpawns().remove(bloc)) {
            return true;
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/editor/item/EditorEvents.java - About 1 hr to fix

Method canMove has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @EventHandler
    public void canMove(PlayerMoveEvent e) {
        DPlayer dPlayer = main.getDPlayerManager().getPlayer(e.getPlayer().getUniqueId());
        if (dPlayer == null) {
            return;
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/events/MainEvents.java - About 1 hr to fix

Method initConnection has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void initConnection() {
        loadValues();
        if (!main.getToggles().usingSQL) {
            return;
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/mysql/MySQL_Connect.java - About 1 hr to fix

Method reInitConnection has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public boolean reInitConnection() {
        loadValues();

        try {
            if (connection != null && !connection.isClosed()) {
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/mysql/MySQL_Connect.java - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void countDownBleep(int timeLeft) {
        for (DPlayer player : players) {
            Player actual = player.getPlayer();
            actual.spigot().sendMessage(ChatMessageType.ACTION_BAR,
                    TextComponent.fromLegacyText(ChatColor.translateAlternateColorCodes('&',
Severity: Major
Found in src/main/java/noahnok/dbdl/files/game/DGame.java and 1 other location - About 1 hr to fix
src/main/java/noahnok/dbdl/files/game/DGame.java on lines 342..352

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void gameStartBleep(int timeLeft) {
        for (DPlayer player : players) {
            Player actual = player.getPlayer();
            actual.spigot().sendMessage(ChatMessageType.ACTION_BAR,
                    TextComponent.fromLegacyText(ChatColor.translateAlternateColorCodes('&',
Severity: Major
Found in src/main/java/noahnok/dbdl/files/game/DGame.java and 1 other location - About 1 hr to fix
src/main/java/noahnok/dbdl/files/game/DGame.java on lines 331..340

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method checkTableExists has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void checkTableExists() {
        new BukkitRunnable() {
            @Override
            public void run() {
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/mysql/MySQL_Connect.java - About 1 hr to fix

Method saveArenasToFile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void saveArenasToFile() {
        for (DArena arena : arenas) {
            String path = "arenas." + arena.getId() + ".";
            FileConfiguration config = main.getArenasConfig().getConfig();
            List<String> gamemodeStrings = new ArrayList<>();
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/DArenaManager.java - About 1 hr to fix

Method isArenaBlock has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private boolean isArenaBlock(DArena a, Location bloc) {
        if (a.getPossibleChestSpawns().contains(bloc)) {
            return true;
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/editor/item/EditorEvents.java - About 1 hr to fix

Method uploadUserStats has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void uploadUserStats(final DPlayer p) {
        if (!main.getToggles().usingSQL) {
            return;
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/mysql/MySQL_Connect.java - About 1 hr to fix

Method spawnExitGates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private void spawnExitGates(DGame game) {
        for (ExitGate gate : game.getArena().getExitGateLocations()) {
            for (Location loc : gate.getLocs()) {
                loc.getBlock().setType(Material.IRON_FENCE);
            }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/game/DGameManager.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method removeArenaBlock has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private boolean removeArenaBlock(DArena a, Location bloc) {
        if (a.getPossibleChestSpawns().remove(bloc)) {
            return true;
        }
Severity: Minor
Found in src/main/java/noahnok/dbdl/files/utils/editor/item/EditorEvents.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language