uruba/FinanCalc

DebtAmortizator has 24 functions (exceeds 20 allowed). Consider refactoring.

Open

    class DebtAmortizator extends CalculatorAbstract
    {
        /** @var  RepaymentInstance[] */
        // list of individual debt's repayments as an array of RepaymentInstance objects
        protected $debtRepayments;

Avoid variables with short names like $i. Configured minimum length is 3.

Open

            $i = 1;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Each class must be in a file by itself

Open

    class RepaymentInstance

• Exclude checks
  • Disable engine
  • Disable check

The closing brace for the class must go on the next line after the body

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 16 spaces, found 12

Open

            "debtSingleRepayment",

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 16 spaces, found 12

Open

            "debtRepayments" => "debtRepaymentsAsArrays"

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 16 spaces, found 12

Open

            "debtLength" =>

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 16 spaces, found 12

Open

            "debtInterest",

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 16 spaces, found 12

Open

            "debtDiscountFactor",

• Exclude checks
  • Disable engine
  • Disable check