Sign upLogin

vaa87/project-lvl2-s253

View on GitHub
Star

Showing 14 of 14 total issues

Function genAST has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function genAST($array1, $array2)
{
    $arrayUniqueKey = arrayUniqueKey($array1, $array2);
    if (!is_array($array1)) {
        $array1 =[];
Severity: Minor
Found in src/genAST.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderBody has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderBody($astTree, $level = 1)
{
    $iterAdded = function ($value, $level) {
        $str = getIndent($level-1) . "  + " . $value['key'] . ": " . stringify($value['newValue'], $level) . PHP_EOL;
        return $str;
Severity: Minor
Found in src/renderPretty.php - About 1 hr to fix

    Method render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function render($astTree, $path = "")
{
    $iterAdded = function ($value, $path) {
        $str = "Property '$path{$value['key']}' was added with value: '" . stringify($value['newValue'])
            . "'" . PHP_EOL;
    Severity: Minor
    Found in src/renderPlain.php - About 1 hr to fix

      Method genAST has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function genAST($array1, $array2)
{
    $arrayUniqueKey = arrayUniqueKey($array1, $array2);
    if (!is_array($array1)) {
        $array1 =[];
      Severity: Minor
      Found in src/genAST.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function parsingString($stringFromFile, $extensionFile)
{
    if (!in_array($extensionFile, ["yaml", "yml", "json"])) {
        throw new Exception("The extension files is not: 'yaml', 'yml', 'json'.\n" . PHP_EOL);
    }
        Severity: Minor
        Found in src/parsers.php and 1 other location - About 55 mins to fix
        src/render.php on lines 4..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function render($astTree, $format)
{

    if (!in_array($format, ["pretty", "plain", "json"])) {
        throw new Exception("The format output is not: 'pretty', 'plain', 'json'.\n" . PHP_EOL);
        Severity: Minor
        Found in src/render.php and 1 other location - About 55 mins to fix
        src/parsers.php on lines 6..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

            return $strResult;
        Severity: Major
        Found in src/renderPlain.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $str;
          Severity: Major
          Found in src/renderPlain.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $str;
            Severity: Major
            Found in src/renderPretty.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return $strResult;
              Severity: Major
              Found in src/renderPretty.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $item;
                Severity: Major
                Found in src/renderPlain.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $item;
                  Severity: Major
                  Found in src/renderPretty.php - About 30 mins to fix

                    Function stringify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function stringify($arg, $level = 1)
{
    if (is_bool($arg)) {
        if ($arg == true) {
            $result = 'true';
                    Severity: Minor
                    Found in src/renderPretty.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function stringify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function stringify($arg)
{
    if (is_bool($arg)) {
        if ($arg == true) {
            $result = 'true';
                    Severity: Minor
                    Found in src/renderPlain.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language