vaimo/composer-patches

View on GitHub

Showing 970 of 970 total issues

File ListCommand.php has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Copyright © Vaimo Group. All rights reserved.
 * See LICENSE_VAIMO.txt for license details.
 */
Severity: Minor
Found in src/Composer/Commands/ListCommand.php - About 3 hrs to fix

    Method execute has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $composer = $this->getComposer();
    
            $isDevMode = !$input->getOption('no-dev');
    Severity: Major
    Found in src/Composer/Commands/ListCommand.php - About 2 hrs to fix

      Method getList has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getList(PluginConfig $pluginConfig)
          {
              $patcherConfig = $pluginConfig->getPatcherConfig();
              $composer = $this->composerContext->getLocalComposer();
              $composerConfig = clone $composer->getConfig();
      Severity: Major
      Found in src/Patch/DefinitionList/Loader/ComponentPool.php - About 2 hrs to fix

        Method configure has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function configure()
            {
                $this->setName('patch');
                $this->setDescription('Apply registered patches to current project');
        
        
        Severity: Major
        Found in src/Composer/Commands/PatchCommand.php - About 2 hrs to fix

          Method configure has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function configure()
              {
                  parent::configure();
          
                  $this->setName('patch:list');
          Severity: Major
          Found in src/Composer/Commands/ListCommand.php - About 2 hrs to fix

            Method create has 63 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function create(LoaderComponents $loaderComponentsPool, PluginConfig $pluginConfig, $devMode = false)
                {
                    $installationManager = $this->composer->getInstallationManager();
            
                    $rootPackage = $this->composer->getPackage();
            Severity: Major
            Found in src/Factories/PatchesLoaderFactory.php - About 2 hrs to fix

              Method getPatcherConfig has 61 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getPatcherConfig()
                  {
                      return array(
                          Config::PATCHER_FILE => array(),
                          Config::PATCHER_FILE_DEV => array(),
              Severity: Major
              Found in src/Config/Defaults.php - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php
                /**
                 * Copyright © Vaimo Group. All rights reserved.
                 * See LICENSE_VAIMO.txt for license details.
                 */
                Severity: Major
                Found in src/Composer/Commands/RedoCommand.php and 1 other location - About 2 hrs to fix
                src/Composer/Commands/UndoCommand.php on lines 1..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 130.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php
                /**
                 * Copyright © Vaimo Group. All rights reserved.
                 * See LICENSE_VAIMO.txt for license details.
                 */
                Severity: Major
                Found in src/Composer/Commands/UndoCommand.php and 1 other location - About 2 hrs to fix
                src/Composer/Commands/RedoCommand.php on lines 1..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 130.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function resolveValidSubOperations has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function resolveValidSubOperations(array $config, array $subConfigKeys)
                    {
                        $subOperationKeys = array_merge(
                            array_filter($subConfigKeys),
                            array(PluginConfig::OS_DEFAULT)
                Severity: Minor
                Found in src/Factories/ConfigFactory.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function sanitizeFileSystem has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function sanitizeFileSystem(array $patches)
                    {
                        foreach ($patches as $patchGroup) {
                            foreach ($patchGroup as $patchInfo) {
                                if (!isset($patchInfo[Patch::TMP]) || !$patchInfo[Patch::TMP]) {
                Severity: Minor
                Found in src/Utils/PatchListUtils.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method apply has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function apply(Repository $repository, array $patches)
                    {
                        $packages = $this->packageCollector->collect($repository);
                        $packagesUpdated = false;
                        $repositoryState = $this->repoStateGenerator->generate($repository);
                Severity: Major
                Found in src/Repository/PatchesApplier.php - About 2 hrs to fix

                  Method create has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function create(PluginConfig $pluginConfig, ListResolver $listResolver, OutputStrategy $outputStrategy)
                      {
                          $installer = $this->composer->getInstallationManager();
                          $downloader = $this->composer->getDownloadManager();
                  
                  
                  Severity: Major
                  Found in src/Factories/PatchesApplierFactory.php - About 2 hrs to fix

                    File ValidateCommand.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /**
                     * Copyright © Vaimo Group. All rights reserved.
                     * See LICENSE_VAIMO.txt for license details.
                     */
                    Severity: Minor
                    Found in src/Composer/Commands/ValidateCommand.php - About 2 hrs to fix

                      Function resolveComparisonResults has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function resolveComparisonResults(array $patchConstraints, array $packages, array $rootRequires)
                          {
                              $comparisonResults = array();
                      
                              foreach ($patchConstraints as $constraintTarget => $version) {
                      Severity: Minor
                      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method process has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function process(array $patches, array $packagesByName)
                          {
                              $ownerName = $this->ownerPackage->getName();
                              $relativePath = PathUtils::composePath($ownerName, 'downloads');
                              $absolutePath = PathUtils::composePath($this->vendorDir, $relativePath);
                      Severity: Major
                      Found in src/Patch/DefinitionList/LoaderComponents/DownloaderComponent.php - About 2 hrs to fix

                        Method normalize has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function normalize($target, $label, array $data, array $ownerConfig)
                            {
                                if ($this->shouldSkip($ownerConfig, $data)) {
                                    return array();
                                }
                        Severity: Major
                        Found in src/Patch/Definition/NormalizerComponents/BasePathComponent.php - About 2 hrs to fix

                          Method applyFile has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function applyFile($filename, $cwd, array $config = array())
                              {
                                  $applierConfig = $this->applierUtils->mergeApplierConfig($this->config, array_filter($config));
                                  $applierConfig = $this->applierUtils->sortApplierConfig($applierConfig);
                                  $patchers = $this->extractArrayValue($applierConfig, PluginConfig::PATCHER_APPLIERS);
                          Severity: Major
                          Found in src/Patch/File/Applier.php - About 2 hrs to fix

                            Function process has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function process(array $patches, array $packagesByName)
                                {
                                    $sortKeys = array(PatchDefinition::BEFORE, PatchDefinition::AFTER);
                            
                                    foreach ($patches as $patchTarget => $packagePatches) {
                            Severity: Minor
                            Found in src/Patch/DefinitionList/LoaderComponents/SorterComponent.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function execute(InputInterface $input, OutputInterface $output)
                                {
                                    $composer = $this->getComposer();
                            
                                    $appIO = $this->getIO();
                            Severity: Minor
                            Found in src/Composer/Commands/PatchCommand.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language