Sign upLogin

vakata/cache

View on GitHub
Star

Showing 72 of 72 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct(string $address = '127.0.0.1:11211', string $prefix = '')
    {
        parent::__construct($prefix);
        $address = parse_url('//' . ltrim($address, '/'));
        if (!$address) { $address = []; }
Severity: Major
Found in src/Memcached.php and 1 other location - About 3 hrs to fix
src/Redis.php on lines 12..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct(string $address = '127.0.0.1:6379', string $prefix = '')
    {
        parent::__construct($prefix);
        $address = parse_url('//' . ltrim($address, '/'));
        if (!$address) { $address = []; }
Severity: Major
Found in src/Redis.php and 1 other location - About 3 hrs to fix
src/Memcached.php on lines 12..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The class SHM has an overall complexity of 60 which is very high. The configured complexity threshold is 50.
Open

class SHM extends AbstractCache
{
    protected SysvSemaphore $semaphore;
    protected SysvSharedMemory $memory;
    /**
Severity: Minor
Found in src/SHM.php by phpmd

Function __construct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(array|string $pool = '127.0.0.1', string $prefix = '')
    {
        parent::__construct($prefix);

        if (is_string($pool)) {
Severity: Minor
Found in src/Libmemcached.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clean has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function clean(): void
    {
        $a = $this->acquire();
        foreach ($this->data['keys'] as $key => $id) {
            if (!shm_has_var($this->memory, $id)) {
Severity: Minor
Found in src/SHM.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method clean has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function clean(): void
    {
        $a = $this->acquire();
        foreach ($this->data['keys'] as $key => $id) {
            if (!shm_has_var($this->memory, $id)) {
Severity: Minor
Found in src/SHM.php - About 1 hr to fix

    Method _read has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _read(): mixed
    {
        switch (fgetc($this->socket)) {
            case '+':
                return trim(fgets($this->socket) ?: '', "\r\n");
    Severity: Minor
    Found in src/Redis.php - About 1 hr to fix

      Method name "_get" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _get(string $key): mixed
      Severity: Minor
      Found in src/SHM.php by phpcodesniffer

      Method name "_set" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _set(string $key, mixed $val, int $exp = 0): void
      Severity: Minor
      Found in src/SHM.php by phpcodesniffer

      Function getSet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getSet(string $key, callable $value, string|int|DateInterval|DateTime $expires = 0): mixed
    {
        $cnt = 0;
        do {
            $temp = $this->get($key, chr(0));
      Severity: Minor
      Found in src/AbstractCache.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method name "_read" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _read(): mixed
      Severity: Minor
      Found in src/Redis.php by phpcodesniffer

      Method name "_del" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _del(string $key): mixed
      Severity: Minor
      Found in src/Redis.php by phpcodesniffer

      Method name "_del" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _del(string $key): void
      Severity: Minor
      Found in src/SHM.php by phpcodesniffer

      Method name "_set" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _set(string $key, string $val, int $exp = 0): bool
      Severity: Minor
      Found in src/Memcached.php by phpcodesniffer

      Method name "_del" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _del(string $key): void
      Severity: Minor
      Found in src/Memcached.php by phpcodesniffer

      Method name "_get" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _get(string $key): mixed
      Severity: Minor
      Found in src/Redis.php by phpcodesniffer

      Method name "_get" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _get(string $key): mixed
      Severity: Minor
      Found in src/Memcached.php by phpcodesniffer

      Method name "_set" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _set(string $key, mixed $val, int $exp = 0): mixed
      Severity: Minor
      Found in src/Redis.php by phpcodesniffer

      Remove error control operator '@' on line 46.
      Open

          public function get(string $key, mixed $default = null): mixed
    {
        $key = $this->prefix . $key;
        $value = $this->server->get($key);
        if ($value === false) {
      Severity: Minor
      Found in src/Libredis.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      Remove error control operator '@' on line 123.
      Open

          public function get(string $key, mixed $default = null): mixed
    {
        $key = $this->prefix . $key;
        $val = '';
        $cnt = 0;
      Severity: Minor
      Found in src/Memcached.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      Severity
      Category
      Status
      Source
      Language