Sign upLogin

vakata/certificate

View on GitHub
Star

Showing 202 of 202 total issues

Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function validate(string $data, bool $hashOnly = false) : array
    {
        $signers = $this->getSigners();
        foreach ($this->p7s->toArray()['data']['signerInfos'] as $k => $v) {
            $signers[$k]['valid'] = false;
Severity: Minor
Found in src/P7S.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Opening brace should be on the same line as the declaration
Open

        {
Severity: Minor
Found in src/Certificate.php by phpcodesniffer

Space found before closing bracket of FOREACH loop
Open

        foreach (
Severity: Minor
Found in src/Certificate.php by phpcodesniffer

Function validEGN has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function validEGN(string $value) : bool
    {
        if (!ctype_digit($value) || strlen($value) !== 10) {
            return false;
        }
Severity: Minor
Found in src/NaturalPerson.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Space found after opening bracket of FOREACH loop
Open

        foreach (
Severity: Minor
Found in src/Certificate.php by phpcodesniffer

Function getCRLPoints has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getCRLPoints(bool $httpOnly = true) : array
    {
        $points = $this->cert['extensions'][ASN1::TextToOID('cRLDistributionPoints')] ?? [];
        $result = [];
        foreach ($points as $point) {
Severity: Minor
Found in src/Certificate.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Remove error control operator '@' on line 1042.
Open

    public function isRevokedCRL(array $ca = [], int $time = null) : bool
    {
        if ($time === null) {
            $time = time();
        }
Severity: Minor
Found in src/Certificate.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '232', column '28').
Open

                $tmp = new \DOMDocument();
Severity: Minor
Found in src/P7S.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 972.
Open

    public function isRevokedOCSP() : bool
    {
        $ocsp = $this->getOCSPPoints();
        if (count($ocsp)) {
            if ($this->isSelfSigned()) {
Severity: Minor
Found in src/Certificate.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '209', column '20').
Open

        $xml = new \DOMDocument();
Severity: Minor
Found in src/P7S.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '735', column '17').
Open

            new \RecursiveIteratorIterator(
Severity: Minor
Found in src/Certificate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '736', column '21').
Open

                new \RecursiveArrayIterator($this->cert['extensions'][ASN1::TextToOID('certificatePolicies')] ?? [])
Severity: Minor
Found in src/Certificate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function getOCSPPoints has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getOCSPPoints() : array
    {
        $urls = [];
        $ocsp = $this->cert['extensions'][ASN1::TextToOID('authorityInfoAccess')] ?? [];
        foreach ($ocsp as $loc) {
Severity: Minor
Found in src/Certificate.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getKeyUsage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getKeyUsage() : array
    {
        $kusage = $this->cert['extensions'][ASN1::TextToOID('keyUsage')] ?? null;
        if (!isset($kusage)) {
            return [];
Severity: Minor
Found in src/Certificate.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\vakata\asn1\ASN1' in method 'parseLegacyCertificate'.
Open

                                $cert['subject'][ASN1::TextToOID('commonName')],
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\vakata\asn1\ASN1' in method 'parseLegacyCertificate'.
Open

                        [ASN1::TextToOID('organizationalUnit')],
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\vakata\asn1\ASN1' in method 'parseLegacyCertificate'.
Open

                                $compacted[ASN1::TextToOID('countryOfCitizenship')] ?? 'BG',
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\vakata\asn1\ASN1' in method 'parseLegacyCertificate'.
Open

                            $cert['subject'][ASN1::TextToOID('commonName')],
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\vakata\asn1\ASN1' in method 'getSubjectData'.
Open

        $original = $this->cert['extensions'][ASN1::TextToOID('subjectAltName')] ?? [];
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\vakata\asn1\ASN1' in method 'parseLegacyCertificate'.
Open

                            $cert['subject'][ASN1::TextToOID('countryName')] ?? null,
Severity: Minor
Found in src/Certificate.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language