Showing 10 of 10 total issues
Function get
has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring. Open
public function get($key, array $replace = [], string $default = null) : string
{
if (is_array($key)) {
$found = false;
$value = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class Intl has an overall complexity of 50 which is very high. The configured complexity threshold is 50. Open
class Intl
{
protected $data = [];
protected $used = [];
- Exclude checks
The class Intl has 11 public methods. Consider refactoring Intl to keep number of public methods under 10. Open
class Intl
{
protected $data = [];
protected $used = [];
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
Method get
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function get($key, array $replace = [], string $default = null) : string
{
if (is_array($key)) {
$found = false;
$value = null;
Method date
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function date(string $format = 'short', int $timestamp = null) : string
{
if ($timestamp === null) {
$timestamp = time();
}
Remove error control operator '@' on line 89. Open
public function addFile(string $location, string $format = 'json') : self
{
if (!is_file($location)) {
throw new IntlException('Invalid file');
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Avoid too many return
statements within this method. Open
return $val === false ? $default : $val;
The method get() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
public function get($key, array $replace = [], string $default = null) : string
{
if (is_array($key)) {
$found = false;
$value = null;
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Expected 1 newline at end of file; 0 found Open
}
- Exclude checks
Expected 1 newline at end of file; 0 found Open
}
- Exclude checks