Sign upLogin

vakata/router

View on GitHub
Star

Showing 13 of 13 total issues

The class Router has an overall complexity of 58 which is very high. The configured complexity threshold is 50.
Open

class Router implements RouterInterface
{
    protected $preprocessors = [];
    protected $routes = [];
    protected $prefix = '';
Severity: Minor
Found in src/Router.php by phpmd

The class Router has 11 public methods. Consider refactoring Router to keep number of public methods under 10.
Open

class Router implements RouterInterface
{
    protected $preprocessors = [];
    protected $routes = [];
    protected $prefix = '';
Severity: Minor
Found in src/Router.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Function add has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function add($method, $url = null, $handler = null) : RouterInterface
    {
        $temp = [ 'method' => [ 'GET', 'POST' ], 'url' => '', 'handler' => null ];
        foreach (func_get_args() as $arg) {
            if (is_callable($arg)) {
Severity: Minor
Found in src/Router.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compileSegment has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function compileSegment(string $url) : string
    {
        $all = preg_match('(^\{[^\}]+\}$)', $url);
        if (!preg_match('(([^{]*)\{([^}]+)\}([^{]*))i', $url)) {
            return '(?:'.preg_quote($url).')/';
Severity: Major
Found in src/Router.php - About 2 hrs to fix

    Function run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function run(string $request, string $verb = 'GET')
    {
        $request = $this->path($request);
        $matches = [];
        if (isset($this->routes[$verb])) {
    Severity: Minor
    Found in src/Router.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function add($method, $url = null, $handler = null) : RouterInterface
    {
        $temp = [ 'method' => [ 'GET', 'POST' ], 'url' => '', 'handler' => null ];
        foreach (func_get_args() as $arg) {
            if (is_callable($arg)) {
    Severity: Minor
    Found in src/Router.php - About 1 hr to fix

      Remove error control operator '@' on line 54.
      Open

          protected function compile(string $url, bool $full = true) : string
    {
        $url = array_filter(
            explode('/', trim($url, '/')),
            function ($v) {
      Severity: Minor
      Found in src/Router.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      The method add() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public function add($method, $url = null, $handler = null) : RouterInterface
    {
        $temp = [ 'method' => [ 'GET', 'POST' ], 'url' => '', 'handler' => null ];
        foreach (func_get_args() as $arg) {
            if (is_callable($arg)) {
      Severity: Minor
      Found in src/Router.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method compileSegment() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
      Open

          protected function compileSegment(string $url) : string
    {
        $all = preg_match('(^\{[^\}]+\}$)', $url);
        if (!preg_match('(([^{]*)\{([^}]+)\}([^{]*))i', $url)) {
            return '(?:'.preg_quote($url).')/';
      Severity: Minor
      Found in src/Router.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Usage of ELSE IF is discouraged; use ELSEIF instead
      Open

                  } else if (in_array($arg, ['GET', 'HEAD', 'POST', 'PATCH', 'DELETE', 'PUT', 'OPTIONS', 'REPORT'])) {
      Severity: Minor
      Found in src/Router.php by phpcodesniffer

      Opening brace should be on a new line
      Open

          public function getPrefix() : string {
      Severity: Minor
      Found in src/Router.php by phpcodesniffer

      Opening brace should be on a new line
      Open

          public function group(string $prefix, callable $handler) : RouterInterface {
      Severity: Minor
      Found in src/Router.php by phpcodesniffer

      Opening brace should be on a new line
      Open

          public function setPrefix(string $prefix) : RouterInterface {
      Severity: Minor
      Found in src/Router.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language