Sign upLogin

valor-software/angular2-bootstrap

View on GitHub
Star
src/timepicker/reducer/timepicker.reducer.ts

Summary

Maintainability
F
3 days
Test Coverage

Function timepickerReducer has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

export function timepickerReducer(state = initialState, action: Action) {
  switch (action.type) {
    case TimepickerActions.WRITE_VALUE: {
      return Object.assign({}, state, { value: action.payload });
    }
Severity: Minor
Found in src/timepicker/reducer/timepicker.reducer.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function timepickerReducer has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function timepickerReducer(state = initialState, action: Action) {
  switch (action.type) {
    case TimepickerActions.WRITE_VALUE: {
      return Object.assign({}, state, { value: action.payload });
    }
Severity: Major
Found in src/timepicker/reducer/timepicker.reducer.ts - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

            return state;
    Severity: Major
    Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return Object.assign({}, state, { value: _newTime });
      Severity: Major
      Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return state;
        Severity: Major
        Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return Object.assign({}, state, { value: _newTime });
          Severity: Major
          Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return Object.assign({}, state, { value: _newTime });
            Severity: Major
            Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return state;
              Severity: Major
              Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return state;
                Severity: Major
                Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return Object.assign({}, state, _newState);
                  Severity: Major
                  Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return state;
                    Severity: Major
                    Found in src/timepicker/reducer/timepicker.reducer.ts - About 30 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case TimepickerActions.CHANGE_SECONDS: {
      if (
        !canChangeValue(state.config, action.payload) ||
        !canChangeSeconds(action.payload, state.controls)
      ) {
                      Severity: Major
                      Found in src/timepicker/reducer/timepicker.reducer.ts and 2 other locations - About 5 hrs to fix
                      src/timepicker/reducer/timepicker.reducer.ts on lines 45..60
                      src/timepicker/reducer/timepicker.reducer.ts on lines 62..77

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 150.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case TimepickerActions.CHANGE_MINUTES: {
      if (
        !canChangeValue(state.config, action.payload) ||
        !canChangeMinutes(action.payload, state.controls)
      ) {
                      Severity: Major
                      Found in src/timepicker/reducer/timepicker.reducer.ts and 2 other locations - About 5 hrs to fix
                      src/timepicker/reducer/timepicker.reducer.ts on lines 45..60
                      src/timepicker/reducer/timepicker.reducer.ts on lines 79..96

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 150.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case TimepickerActions.CHANGE_HOURS: {
      if (
        !canChangeValue(state.config, action.payload) ||
        !canChangeHours(action.payload, state.controls)
      ) {
                      Severity: Major
                      Found in src/timepicker/reducer/timepicker.reducer.ts and 2 other locations - About 5 hrs to fix
                      src/timepicker/reducer/timepicker.reducer.ts on lines 62..77
                      src/timepicker/reducer/timepicker.reducer.ts on lines 79..96

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 150.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status