Sign upLogin

valor-software/ng2-bootstrap

View on GitHub
Star
src/datepicker/reducer/bs-datepicker.reducer.ts

Summary

Maintainability
F
5 days
Test Coverage

Function bsDatepickerReducer has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function bsDatepickerReducer(state = initialDatepickerState,
                                    action: Action): BsDatepickerState {
  switch (action.type) {
    case BsDatepickerActions.CALCULATE: {
      return calculateReducer(state);
Severity: Major
Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 3 hrs to fix

    File bs-datepicker.reducer.ts has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // tslint:disable:max-file-line-count
import { BsDatepickerState, initialDatepickerState } from './bs-datepicker.state';
import { Action } from '../../mini-ngrx/index';
import { BsDatepickerActions } from './bs-datepicker.actions';
import { calcDaysCalendar } from '../engine/calc-days-calendar';
    Severity: Minor
    Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 2 hrs to fix

      Function bsDatepickerReducer has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      export function bsDatepickerReducer(state = initialDatepickerState,
                                    action: Action): BsDatepickerState {
  switch (action.type) {
    case BsDatepickerActions.CALCULATE: {
      return calculateReducer(state);
      Severity: Minor
      Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function flagReducer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function flagReducer(state: BsDatepickerState,
                     action: Action): BsDatepickerState {
  if (state.view.mode === 'day') {
    const flaggedMonths = state.formattedMonths.map(
      (formattedMonth, monthIndex) =>
      Severity: Minor
      Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 1 hr to fix

        Function calculateReducer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function calculateReducer(state: BsDatepickerState): BsDatepickerState {
  // how many calendars
  const displayMonths = state.displayMonths;
  // use selected date on initial rendering if set
  let viewDate = state.view.date;
        Severity: Minor
        Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 1 hr to fix

          Function formatReducer has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function formatReducer(state: BsDatepickerState,
                       action: Action): BsDatepickerState {
  if (state.view.mode === 'day') {
    const formattedMonths = state.monthsModel.map((month, monthIndex) =>
      formatDaysCalendar(month, getFormatOptions(state), monthIndex)
          Severity: Minor
          Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 1 hr to fix

            Function calculateReducer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function calculateReducer(state: BsDatepickerState): BsDatepickerState {
  // how many calendars
  const displayMonths = state.displayMonths;
  // use selected date on initial rendering if set
  let viewDate = state.view.date;
            Severity: Minor
            Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function formatReducer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function formatReducer(state: BsDatepickerState,
                       action: Action): BsDatepickerState {
  if (state.view.mode === 'day') {
    const formattedMonths = state.monthsModel.map((month, monthIndex) =>
      formatDaysCalendar(month, getFormatOptions(state), monthIndex)
            Severity: Minor
            Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                  return Object.assign({}, state, newState);
            Severity: Major
            Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return Object.assign({}, state, newState);
              Severity: Major
              Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return Object.assign({}, state, newState);
                Severity: Major
                Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return Object.assign({}, state, newState);
                  Severity: Major
                  Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return state;
                    Severity: Major
                    Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return Object.assign({}, state, newState);
                      Severity: Major
                      Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return Object.assign({}, state, {
        maxDate: action.payload
      });
                        Severity: Major
                        Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return Object.assign({}, state, { hoveredDate: action.payload });
                          Severity: Major
                          Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return Object.assign({}, state, {
        minDate: action.payload
      });
                            Severity: Major
                            Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return Object.assign({}, state, {
        isDisabled: action.payload
      });
                              Severity: Major
                              Found in src/datepicker/reducer/bs-datepicker.reducer.ts - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  if (state.view.mode === 'year') {
    const yearsCalendarFlagged = state.yearsCalendarModel.map(
      (formattedMonth, yearIndex) =>
        flagYearsCalendar(formattedMonth, {
          isDisabled: state.isDisabled,
                                Severity: Major
                                Found in src/datepicker/reducer/bs-datepicker.reducer.ts and 1 other location - About 4 hrs to fix
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 286..300

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 119.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  if (state.view.mode === 'month') {
    const flaggedMonthsCalendar = state.monthsCalendar.map(
      (formattedMonth, monthIndex) =>
        flagMonthsCalendar(formattedMonth, {
          isDisabled: state.isDisabled,
                                Severity: Major
                                Found in src/datepicker/reducer/bs-datepicker.reducer.ts and 1 other location - About 4 hrs to fix
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 302..316

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 119.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  if (state.view.mode === 'month') {
    const monthsCalendar = new Array(displayMonths);
    for (
      let calendarIndex = 0;
      calendarIndex < displayMonths;
                                Severity: Major
                                Found in src/datepicker/reducer/bs-datepicker.reducer.ts and 2 other locations - About 3 hrs to fix
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 227..243
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 245..261

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 113.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  if (state.view.mode === 'month') {
    const monthsCalendar = new Array(displayMonths);
    for (
      let calendarIndex = 0;
      calendarIndex < displayMonths;
                                Severity: Major
                                Found in src/datepicker/reducer/bs-datepicker.reducer.ts and 2 other locations - About 3 hrs to fix
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 171..187
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 245..261

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 113.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  if (state.view.mode === 'year') {
    const yearsCalendarModel = new Array(displayMonths);
    for (
      let calendarIndex = 0;
      calendarIndex < displayMonths;
                                Severity: Major
                                Found in src/datepicker/reducer/bs-datepicker.reducer.ts and 2 other locations - About 3 hrs to fix
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 171..187
                                src/datepicker/reducer/bs-datepicker.reducer.ts on lines 227..243

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 113.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status