Sign upLogin

valor-software/ng2-dragula

View on GitHub
Star
libs/ng2-dragula/src/components/dragula.directive.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function ngOnChanges has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  public ngOnChanges(changes: {dragula?: SimpleChange, dragulaModel?: SimpleChange}): void {
    if (changes && changes.dragula) {
      const { previousValue: prev, currentValue: current, firstChange } = changes.dragula;
      const hadPreviousValue = !!prev;
      const hasNewValue = !!current;
Severity: Minor
Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  public setup(): void {
    const checkModel = (group: Group) => {
      if (this.dragulaModel) {
        if (group.drake?.models) {
          group.drake?.models?.push(this.dragulaModel);
Severity: Minor
Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ngOnChanges has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public ngOnChanges(changes: {dragula?: SimpleChange, dragulaModel?: SimpleChange}): void {
    if (changes && changes.dragula) {
      const { previousValue: prev, currentValue: current, firstChange } = changes.dragula;
      const hadPreviousValue = !!prev;
      const hasNewValue = !!current;
Severity: Minor
Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 1 hr to fix

    Function teardown has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      public teardown(groupName: string): void {
    if (this.subs) {
      this.subs.unsubscribe();
    }
    const group = this.dragulaService.find(groupName);
    Severity: Minor
    Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

              if (current) {
            drake.models.splice(prevIndex, 0, current);
          }
    Severity: Major
    Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              } else if (current) {
          // no previous one to remove; just push this one.
          drake.models.push(current);
        }
      Severity: Major
      Found in libs/ng2-dragula/src/components/dragula.directive.ts - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status