Sign upLogin

varvet/godmin

View on GitHub
Star
lib/generators/godmin/resource/resource_generator.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if namespaced?
Severity: Minor
Found in lib/generators/godmin/resource/resource_generator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use meaningful heredoc delimiters.
Open

      END
Severity: Minor
Found in lib/generators/godmin/resource/resource_generator.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if namespaced?
Severity: Minor
Found in lib/generators/godmin/resource/resource_generator.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Use nested module/class definitions instead of compact style.
Open

class Godmin::ResourceGenerator < Godmin::Generators::NamedBase
Severity: Minor
Found in lib/generators/godmin/resource/resource_generator.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status